Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 18 pull requests #24302

Closed
wants to merge 40 commits into from
Closed

Conversation

Thiago Carvalho and others added 30 commits April 9, 2015 18:07
coherence. Skolemized parameters wind up preventing unification.
Surprised we had no test for this! Fixes rust-lang#24241.
A brief introduction to each type, with pointers to the primitive pages
for more info.
"highlight end" and instead add a variant to `RenderSpan`
columns within a line, not just the line numbers. Also try to clarify
and use the term `line_index` when 0-based.
of text (perhaps obtained by span_snippet) and then splice that edited
form back into the original file in the form of a suggestion.
from the current fn. Employ the new `span_suggestion` to show how you
can use `move`.
This is very confusing now that these are inherent methods.
…c to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.
Docs meant that Option is returned though the function returns Result.
Same with integers — docs meant that Option is returned though the function returns Result.
Fill out blank section headers. Copy edit the entire first section.
…labnik

Now that the new TOC has landed, I've started doing an editing pass to get the old content into the right shape. I felt this introduction was significant enough to send as its own PR, though, as it's the introduction.

It's possible that we may just want to replace 'the intro' with this directly, but this PR doesn't do that.
…-message, r=brson

Example showing sample inputs, old message, new message:

https://gist.github.com/nikomatsakis/11126784ac678b7eb6ba

Also adds infrastructure for reporting suggestions "in situ" and does some (minor) cleanups to `CodeMap`.

r? @brson
…labnik

Fill out blank section headers. Copy edit the entire first section.
…failure, r=pnkfelix

Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.

r? @pnkfelix
…=alexcrichton

A brief introduction to each type, with pointers to the primitive pages
for more info.
…tsakis

This is very confusing now that these are inherent methods.
…labnik

...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.

r? @steveklabnik
From [here](http://doc.rust-lang.org/nightly/std/primitive.i8.html):

> `fn rotate_right(self, n: u32) -> i8`
> Shifts the bits to the right by a specified __amount amount__, n, wrapping the truncated bits to the beginning of the resulting integer.
Fixes 'fn from_str_radix' documentation where docs meant that Option is returned, though the function returns Result.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member Author

@bors: r+ p=100

@bors
Copy link
Contributor

bors commented Apr 10, 2015

📌 Commit 6a6c02a has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Apr 10, 2015

⌛ Testing commit 6a6c02a with merge 34f8d78...

@bors
Copy link
Contributor

bors commented Apr 10, 2015

💔 Test failed - auto-mac-32-opt

@steveklabnik
Copy link
Member Author

Ugh, I specifically tested that locally 😭

I'll be able to update this in about half an hour

@steveklabnik
Copy link
Member Author

Actually at all, sorry.

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.