Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More editing work on TRPL #24244

Merged
merged 1 commit into from
Apr 11, 2015
Merged

More editing work on TRPL #24244

merged 1 commit into from
Apr 11, 2015

Conversation

steveklabnik
Copy link
Member

Fill out blank section headers. Copy edit the entire first section.

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)


Congratulations! You have officially written a Rust program. That makes you a
Rust programmer! Welcome.
Rust programmer! Welcome. 👍
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🎉👏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, maybe i should do that :)

@huonw huonw assigned steveklabnik and huonw and unassigned huonw and steveklabnik Apr 9, 2015

This hasn’t bought us a whole lot over our simple use of `rustc`, but think
about the future: when our project has more than one file, we would need to
call `rustc` more than once and pass it a bunch of options to tell it to build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustc will load files as necessary for mods automatically (i.e. not like c/c++ compiler that makes per-file object files etc), so this statement is possibly not what you're trying to convey.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking multi-crate stuff with dependencies. Thoughts on how to allude to that without saying it directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just go with 'more complex'

@steveklabnik
Copy link
Member Author

Updated!

@steveklabnik
Copy link
Member Author

Same here, to fix issues like #24252, I'm going to self-r+ these, if there's other nits, send an issue or PR ❤️

@steveklabnik
Copy link
Member Author

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 10, 2015

📌 Commit 06dc26d has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
bors added a commit that referenced this pull request Apr 10, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 10, 2015
…labnik

 Fill out blank section headers. Copy edit the entire first section.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
bors added a commit that referenced this pull request Apr 10, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
@bors
Copy link
Contributor

bors commented Apr 10, 2015

☔ The latest upstream changes (presumably #24177) made this pull request unmergeable. Please resolve the merge conflicts.

Fill out blank section headers. Copy edit the entire first section.
@steveklabnik
Copy link
Member Author

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 10, 2015

📌 Commit f01dbf2 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 10, 2015
…labnik

Fill out blank section headers. Copy edit the entire first section.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 11, 2015
…labnik

 Fill out blank section headers. Copy edit the entire first section.
@bors bors merged commit f01dbf2 into rust-lang:master Apr 11, 2015
@steveklabnik steveklabnik deleted the more_editing branch April 21, 2015 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants