Use rust-installer for installation #19289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch may be impacted by #19065. |
|
Cargo: rust-lang/cargo#970 |
|
cc @vadimcn |
brson
force-pushed
the
rust-installer
branch
from
3b0a67a to
9a4bf8a
Compare
|
@alexcrichton This is ready to go. |
brson
force-pushed
the
rust-installer
branch
2 times, most recently
from
5301ca7 to
436fe73
Compare
This is just a refactoring of the current installer so that Rust and Cargo use the same codebase. cc rust-lang#16456
brson
force-pushed
the
rust-installer
branch
from
436fe73 to
55aa1e6
Compare
|
Still trying to get this to work correctly on windows. I'll open another later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the install.sh file used by both Cargo and Rust in anticipation of creating a single combined installer for both, per #16456.
There should be no changes in functionality.
The installation script has been moved to a new shared project.
The impacts to Rust are:
make installormake dist,rust-installeritself does yet-another copy of the installation image during its prep.make installthe tarball is built as a side-effect, though it isn't used.We might want to wait a week to land this since I will be OOTO from Wednesday through Sunday and unable to deal with fallout.