Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-installer for installation #970

Closed
wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented Nov 25, 2014

This factors out the install.sh file used by both Cargo and Rust in anticipation of creating a single combined installer for both, per rust-lang/rust#16456.

There should be no changes in functionality.

The installation script has been moved to a new shared project.

The impacts to Cargo are:

  • This adds a submodule that builders will need to initialize. It doesn't add any sort of auto-initialization in configure like Rust uses, so the buildbots will need to change (or configure will need to).
  • When running make install or make dist, rust-installer itself does yet-another copy of the installation image during its prep.
  • When running make install the tarball is built as a side-effect, though it isn't used.

We might want to wait a week to land this since I will be OOTO from Wednesday through Sunday and unable to deal with fallout.

@brson
Copy link
Contributor Author

brson commented Nov 25, 2014

Rust: rust-lang/rust#19289

@brson
Copy link
Contributor Author

brson commented Dec 10, 2014

@alexcrichton This is ready to go.

@brson
Copy link
Contributor Author

brson commented Dec 11, 2014

'make distcheck' is not working correctly on windows still

This is just a refactoring to put Cargo and Rust on the same installer script.
@brson
Copy link
Contributor Author

brson commented Dec 11, 2014

I still haven't proved to myself that this works on windows (lots of spurious failures), but even if this lands hopefully I'll get it figured out before tomorrow's nightlies.

@brson
Copy link
Contributor Author

brson commented Dec 11, 2014

Still does not work correctly on windows.

@brson
Copy link
Contributor Author

brson commented Dec 11, 2014

Still trying to get this to work on windows.

@brson brson closed this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants