Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core::str) mark push/pop/shift byte functions unsafe, rename len functions, and fix replace #1819

Closed
wants to merge 8 commits into from
Closed

(core::str) mark push/pop/shift byte functions unsafe, rename len functions, and fix replace #1819

wants to merge 8 commits into from

Conversation

killerswan
Copy link
Contributor

Various updates to core::str, including:

  • move push_byte, push_bytes, pop_byte, and shift_byte into str::unsafe and mark them unsafe
  • rename byte_len -> len_bytes
  • rename char_len -> len / len_chars
  • rename byte_len_range -> substr_len_bytes and
  • rename char_len_range -> substr_len_chars
  • fix replace and starts_with (for UTF-8) and add more unicode find/contains/replace test cases

@killerswan
Copy link
Contributor Author

Also, I'm not exactly sure why uasi's commit is in this batch, since it is already in master. Have to do more rebasing?

@killerswan killerswan closed this Feb 12, 2012
@killerswan
Copy link
Contributor Author

Closed, tried something else, here at #1820, which looks looks cluttered in the same way.

@killerswan killerswan mentioned this pull request Feb 12, 2012
Merged
marijnh added a commit that referenced this pull request Mar 27, 2012
@marijnh
Support returning from loop blocks
064f82d 
The code is somewhat invasive, but it seems hard to do this in a
clean way, since the design itself involves a bunch of 'action
at a distance'.

Issue #1819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killerswan @uasi