Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(core::str) mark push/pop/shift byte functions unsafe, rename len functions, and fix replace #1820

Closed
wants to merge 8 commits into from

Conversation

killerswan
Copy link
Contributor

Various updates to core::str, including:

  • move push_byte, push_bytes, pop_byte, and shift_byte into str::unsafe and mark them unsafe
  • rename byte_len -> len_bytes
  • rename char_len -> len / len_chars
  • rename byte_len_range -> substr_len_bytes and
  • rename char_len_range -> substr_len_chars
  • fix replace and starts_with (for UTF-8) and add more unicode find/contains/replace test cases

@brson
Copy link
Contributor

brson commented Feb 12, 2012

This has a weird duplicate of an existing commit: 09b2f8d

@killerswan
Copy link
Contributor Author

I need to figure out how to reset my master branch, after some accidental rebasing...

@killerswan killerswan closed this Feb 12, 2012
celinval pushed a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants