Skip to content

[rustdoc] Fix wrong i tooltip icon #144913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[rustdoc] Fix wrong i tooltip icon #144913

wants to merge 2 commits into from
+35 −2

Conversation

GuillaumeGomez
Copy link
Member

Current wrong display:

Screenshot From 2025-08-04 17-42-38

With the fix:

image

r? @fmease

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

fmease is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rust-log-analyzer

This comment has been minimized.

Sign in to view
lolbinarycat
lolbinarycat reviewed Aug 4, 2025
View reviewed changes
tests/rustdoc-gui/tooltips.goml
@@ -0,0 +1,15 @@
// This test checks that the right font is applied to the `i` tooltip element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably mention this is technically a regression test for #144778 (and also the PR description should mention this fixes that issue)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not. Likely the same bug but I can't reproduce #144778 so I'll wait for @fmease to confirm that the fix I provide them is working as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, it doesn't address #144778.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving conversation then. Thanks for confirming it @fmease!

lolbinarycat
lolbinarycat reviewed Aug 4, 2025
View reviewed changes
tests/rustdoc-gui/src/test_docs/lib.rs
@@ -767,3 +767,17 @@ pub mod impls_indent {
pub fn bar() {}
}
}

pub mod tooltips {
pub struct X;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also try with <div class="warning"></div> like in the original issue, just to make sure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like said above, can't reproduce the bug for this case. ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird.

@GuillaumeGomez
Copy link
Member Author

@bors r=fmease rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

📌 Commit 2260749 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolbinarycat lolbinarycat lolbinarycat left review comments

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rustbot @rust-log-analyzer @bors @fmease @lolbinarycat