Skip to content

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps #143929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petrochenkov
Copy link
Contributor

This affects the next lints:

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 14, 2025
@petrochenkov
Copy link
Contributor Author

@bors try

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025
bors added a commit that referenced this pull request Jul 14, 2025
Mark all deprecation lints in name resolution as deny-by-default and report-in-deps

This affects the next lints:
- `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - no tracking issue
- `LEGACY_DERIVE_HELPERS` - #79202
- `PRIVATE_MACRO_USE` - #120192
- `OUT_OF_SCOPE_MACRO_CALLS` - no tracking issue
@bors
Copy link
Collaborator

bors commented Jul 14, 2025

⌛ Trying commit 624f453 with merge dd2d87b...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-19-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- compiler/rustc_lint_defs/src/builtin.rs - builtin::OUT_OF_SCOPE_MACRO_CALLS (line 4833) stdout ----
error: cannot find macro `in_root` in the current scope when looking from the crate root
 --> compiler/rustc_lint_defs/src/builtin.rs:4834:10
  |
2 | #![doc = in_root!()]
  |          ^^^^^^^ not found from the crate root
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #124535 <https://github.com/rust-lang/rust/issues/124535>
  = help: import `macro_rules` with `use` to make it callable above its definition
---
    compiler/rustc_lint_defs/src/builtin.rs - builtin::OUT_OF_SCOPE_MACRO_CALLS (line 4833)

test result: FAILED. 63 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 963.64ms

error: doctest failed, to rerun pass `-p rustc_lint_defs --doc`
Build completed unsuccessfully in 0:26:44
  local time: Mon Jul 14 15:40:23 UTC 2025
  network time: Mon, 14 Jul 2025 15:40:23 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Jul 14, 2025

☀️ Try build successful - checks-actions
Build commit: dd2d87b (dd2d87b6cc31907ae305875eb6be399783dc0256)

@petrochenkov
Copy link
Contributor Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-143929 created and queued.
🤖 Automatically detected try build dd2d87b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-143929 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants