Skip to content

Use less HIR in check_private_in_public. #144276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Use less HIR in check_private_in_public. #144276

merged 1 commit into from
Jul 24, 2025
+92 −124

Conversation

cjgillot
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2025
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144276 - cjgillot:no-hir-privacy, r=<try>
ba37341 
Use less HIR in check_private_in_public.

r? `@petrochenkov`
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

⌛ Trying commit 6e8762f with merge ba37341...

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

☀️ Try build successful - checks-actions
Build commit: ba37341 (ba37341dfaa034a264794ad90ff9ebe1c1c64d06)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ba37341): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% [-1.1%, -1.1%] 3
All ❌✅ (primary) - - 0

Cycles

Results (primary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.2% [2.0%, 2.3%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [-2.3%, 2.3%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.536s -> 464.367s (-0.25%)
Artifact size: 374.60 MiB -> 374.57 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2025
@petrochenkov
Copy link
Contributor

@bors r+ rollup=maybe

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit 6e8762f has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
f50023d 
…enkov

Use less HIR in check_private_in_public.

r? `@petrochenkov`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
8f36601 
…enkov

Use less HIR in check_private_in_public.

r? ``@petrochenkov``
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
845af3c 
…enkov

Use less HIR in check_private_in_public.

r? ```@petrochenkov```
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144325 - matthiaskrgr:rollup-0jbo4dl, r=matthiaskrgr
fb35347 
Rollup of 8 pull requests

Successful merges:

 - #144094 (Ensure we codegen the main fn)
 - #144173 (Remove tidy checks for `tests/ui/issues/`)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144234 (Fix broken TLS destructors on 32-bit win7)
 - #144256 (Don't ICE on non-TypeId metadata within TypeId)
 - #144272 (resolve: Make disambiguators for underscore bindings module-local (take 2))
 - #144276 (Use less HIR in check_private_in_public.)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
f5faff6 
…enkov

Use less HIR in check_private_in_public.

r? ````@petrochenkov````
@fmease fmease mentioned this pull request Jul 23, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
6ae4bbc 
…enkov

Use less HIR in check_private_in_public.

r? `````@petrochenkov`````
@fmease fmease mentioned this pull request Jul 23, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
cf6fdf6 
…enkov

Use less HIR in check_private_in_public.

r? ``````@petrochenkov``````
@fmease fmease mentioned this pull request Jul 24, 2025
Closed
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144384 - fmease:rollup-fqlje3j, r=fmease
a5f68b3 
Rollup of 15 pull requests

Successful merges:

 - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links)
 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#144276 - cjgillot:no-hir-privacy, r=petroch…
6108d5e 
…enkov

Use less HIR in check_private_in_public.

r? ```````@petrochenkov```````
@fmease fmease mentioned this pull request Jul 24, 2025
Closed
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144387 - fmease:rollup-nh0gn9t, r=fmease
5bcd716 
Rollup of 16 pull requests

Successful merges:

 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144278 (add Rev::into_inner)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jul 24, 2025
Merged
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144398 - fmease:rollup-z6vq7mi, r=fmease
246733a 
Rollup of 15 pull requests

Successful merges:

 - #143374 (Unquerify extern_mod_stmt_cnum.)
 - #143838 (std: net: uefi: Add support to query connection data)
 - #144014 (don't link to the nightly version of the Edition Guide in stable lints)
 - #144094 (Ensure we codegen the main fn)
 - #144218 (Use serde for target spec json deserialize)
 - #144221 (generate elf symbol version in raw-dylib)
 - #144240 (Add more test case to check if the false note related to sealed trait suppressed)
 - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2)
 - #144276 (Use less HIR in check_private_in_public.)
 - #144278 (add Rev::into_inner)
 - #144317 (pass build.npm from bootstrap to tidy and use it for npm install)
 - #144320 (rustdoc: avoid allocating a temp String for aliases in search index)
 - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion)
 - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding)
 - #144358 (Stop using the old `validate_attr` logic for stability attributes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ac4ffdc into rust-lang:master Jul 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 24, 2025
rust-timer added a commit that referenced this pull request Jul 24, 2025
@rust-timer
Unrolled build for #144276
54e02f3 
Rollup merge of #144276 - cjgillot:no-hir-privacy, r=petrochenkov

Use less HIR in check_private_in_public.

r? ````````@petrochenkov````````
@cjgillot cjgillot deleted the no-hir-privacy branch July 24, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cjgillot @rust-timer @bors @petrochenkov @rustbot