Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #136454

Merged
merged 75 commits into from
Feb 3, 2025
Merged

Rollup of 8 pull requests #136454

merged 75 commits into from
Feb 3, 2025

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

oli-obk and others added 30 commits January 27, 2025 10:49
Added a helper to dedup target OS checks
Check fixed args number for variadic function
…-solaris

Set st_fstype of stat on Solaris and Illumos OSes
Use deref_pointer_as instead of deref_pointer
@rustbot rustbot added the rollup A PR which is a rollup label Feb 2, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Feb 2, 2025

📌 Commit a8055f9 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
@bors
Copy link
Contributor

bors commented Feb 2, 2025

⌛ Testing commit a8055f9 with merge 0bafdaf...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136145 (Test validity of pattern types)
 - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets)
 - rust-lang#136403 (Fix malformed error annotations in a UI test)
 - rust-lang#136414 (Shorten error message for callable with wrong return type)
 - rust-lang#136425 (Move `rustc_middle::infer::unify_key`)
 - rust-lang#136426 (Explain why we retroactively change a static initializer to have a different type)
 - rust-lang#136445 (Couple of cleanups to DiagCtxt and EarlyDiagCtxt)
 - rust-lang#136452 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Feb 2, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2025
@RalfJung
Copy link
Member

RalfJung commented Feb 2, 2025

I saw the exact same failure in #136146. I think the aarch64-gnu-debug runner is busted.

Cc @rust-lang/infra
@bors treeclose=100

@RalfJung
Copy link
Member

RalfJung commented Feb 2, 2025

@bors treeclosed=100

@matthiaskrgr
Copy link
Member Author

yeah looks like CI is toast... 🍞
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
@RalfJung
Copy link
Member

RalfJung commented Feb 2, 2025

Hm, oddly the next run of #136146 seems to have made it past the "free up disk space" step? Maybe some fraction of runs still succeeds, so it might be worth trying.

@bors treeclosed-

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

invoke-rc.d: could not determine current runlevel
Failed to stop mysql.service: Connection timed out

See system logs and 'systemctl status mysql.service' for details.

invoke-rc.d: initscript mysql, action "stop" failed.
dpkg: error processing package mysql-server-8.0 (--remove):
 installed mysql-server-8.0 package pre-removal script subprocess returned error exit status 1
dpkg: too many errors, stopping
Failed to retrieve unit state: Connection timed out
invoke-rc.d: could not determine current runlevel
Failed to stop mysql.service: Connection timed out


See system logs and 'systemctl status mysql.service' for details.

invoke-rc.d: initscript mysql, action "stop" failed.
Reload daemon failed: Failed to activate service 'org.freedesktop.systemd1': timed out (service_start_timeout=25000ms)

Failed to retrieve unit state: Failed to activate service 'org.freedesktop.systemd1': timed out (service_start_timeout=25000ms)
invoke-rc.d: could not determine current runlevel
Errors were encountered while processing:
 mysql-server-8.0
Processing was halted because there were too many errors.
Processing was halted because there were too many errors.
Error: Timeout was reached
E: Sub-process /usr/bin/dpkg returned an error code (1)
##[error]Process completed with exit code 100.

@workingjubilee
Copy link
Member

cc @marcoieni

@workingjubilee
Copy link
Member

note also #135867

@bors
Copy link
Contributor

bors commented Feb 2, 2025

⌛ Testing commit a8055f9 with merge 613bdd49978298648ed05ace086bd1ecad54b44a...

@bors
Copy link
Contributor

bors commented Feb 3, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 613bdd4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 3, 2025
@bors bors merged commit 613bdd4 into rust-lang:master Feb 3, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 3, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#136145 Test validity of pattern types 8a81d780e2a5b4ddb3c0362765d57f7c3d8e7c64 (link)
#136339 CompileTest: Add Directives to Ignore arm-unknown-* Targe… f2d7f51ddc02e62d3622c65a242d7d7b0623a285 (link)
#136403 Fix malformed error annotations in a UI test ce40513066958bc298b1ed026ecfe14be49f66b3 (link)
#136414 Shorten error message for callable with wrong return type a347747c04b5392c4806924129dd5402ceb9af35 (link)
#136425 Move rustc_middle::infer::unify_key 4096712327bbad40fb72bf1a550b8b7632b5e160 (link)
#136426 Explain why we retroactively change a static initializer to… 1721e5d3fb39b9e38df733a0ca9b72c1ff7589ee (link)
#136445 Couple of cleanups to DiagCtxt and EarlyDiagCtxt 97add31564128d34833a4bfe31d54188c851e6c3 (link)
#136452 Miri subtree update b615b9aacfbf4d313eb6a36f7b5b1098239cf74e (link)

previous master: 4a43094662

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (613bdd4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-3.4%, -3.2%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.3% [-3.4%, -3.2%] 2

Cycles

Results (secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.802s -> 778.369s (0.07%)
Artifact size: 328.69 MiB -> 328.65 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.