Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of cleanups to DiagCtxt and EarlyDiagCtxt #136445

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Couple of cleanups to DiagCtxt and EarlyDiagCtxt #136445

wants to merge 4 commits into from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 2, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 2, 2025
@bjorn3 bjorn3 force-pushed the diag_ctxt_cleanup branch from c066ee3 to 671045b Compare February 2, 2025 15:36
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@bjorn3 bjorn3 force-pushed the diag_ctxt_cleanup branch from 671045b to 0bdab7e Compare February 2, 2025 15:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 force-pushed the diag_ctxt_cleanup branch from 0bdab7e to 2c6bbcf Compare February 2, 2025 16:07
@bjorn3
Replace ParseSess::set_dcx with DiagCtxt::set_emitter
6a566ee 
Replacing the error emitter doesn't accidentally clear the error count.
@bjorn3 bjorn3 force-pushed the diag_ctxt_cleanup branch from 2c6bbcf to 6a566ee Compare February 2, 2025 16:09
@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Feb 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@oli-obk
Copy link
Contributor

oli-obk commented Feb 2, 2025

r? @oli-obk @bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2025

📌 Commit 6a566ee has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned chenyukang Feb 2, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bjorn3 @rustbot @rust-log-analyzer @oli-obk @bors @chenyukang