-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:Update rustc-dev-guide-book #135337
docs:Update rustc-dev-guide-book #135337
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
This is the commit record for the
|
Since I'm working on Windows, I also can't build rustc-dev-guide, so I don't know why it doesn't detect that Does this mean that mdbook-linkcheck2 is a potential bug? |
This comment has been minimized.
This comment has been minimized.
What happened here? |
You pushed a merge commit; instead, you should use rebases, as per the guide in the comment above. |
Rename `StringReader` to `Lexer` and update links. The `StringReader` struct link is invalid since pr:Merge `TokenTreesReader` into `StringReader`.
51abac5
to
9b1f700
Compare
Fixed in rust-lang/rustc-dev-guide#2208 |
In general, if a PR only modifies rustc-dev-guide, it should be sent against that repository. |
How should this be done? I don't quite understand how a PR for a large repository containing multiple sub-repositories should be targeted to the sub-repositories. Can I do this directly in the rust-lang-rust repository, or should I clone it separately and modify the subrepo and pull the PR? |
If you only modify the code of a subtree (e.g. We tried to document this better in #135770. |
Thanks,I understand. |
…uting, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? `@Kobzol` (or anyone really)
…uting, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? ``@Kobzol`` (or anyone really)
Rollup merge of rust-lang#135770 - jieyouxu:subtree-submodule-contributing, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? ``@Kobzol`` (or anyone really)
…Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang/rust#135337 (comment). r? ``@Kobzol`` (or anyone really)
Rename
StringReader
toLexer
and update links.The
StringReader
struct link is invalid since pr:MergeTokenTreesReader
intoStringReader
.