Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Book build fails on Windows #2204

Open
QingyaoLin opened this issue Jan 10, 2025 · 4 comments
Open

Bug: Book build fails on Windows #2204

QingyaoLin opened this issue Jan 10, 2025 · 4 comments
Labels
C-bug Category: bug O-windows Operating system: Windows WG-rustc-dev-guide Working group: rustc-dev-guide

Comments

@QingyaoLin
Copy link

When I cloned the project, I tried running mdbook build --open and it show:

> gh repo clone rust-lang/rustc-dev-guide
...
> cd rustc-dev-guide
> mdbook build --open
2025-01-10 23:07:31 [INFO] (mdbook::book): Book building has started
2025-01-10 23:07:32 [INFO] (mdbook::book): Running the html backend
2025-01-10 23:07:34 [INFO] (mdbook::book): Running the linkcheck backend
2025-01-10 23:07:34 [INFO] (mdbook::renderer): Invoking the "linkcheck" renderer
2025-01-10 23:07:34 [ERROR] (mdbook::utils): Error: Rendering failed
2025-01-10 23:07:34 [ERROR] (mdbook::utils):    Caused By: Unable to start the backend
2025-01-10 23:07:34 [ERROR] (mdbook::utils):    Caused By: %1 Not a valid Win32 application. (os error 193)

Book build failure!

@jieyouxu jieyouxu added A-linkcheck Area: linkcheck WG-rustc-dev-guide Working group: rustc-dev-guide C-bug Category: bug O-windows Operating system: Windows labels Jan 10, 2025
@JohnTitor JohnTitor removed the A-linkcheck Area: linkcheck label Jan 11, 2025
@JohnTitor
Copy link
Member

Have you installed all the add-ons (check here what's needed)?
If so, I guess this line causes the issue (we use a shell script):

command = "ci/linkcheck.sh"

If you want a copy, you can get it on the web (visit https://rustc-dev-guide.rust-lang.org/ and click the printer mark on top).

Also note that this repo is for developing rustc-dev-guide and it mainly happens on Unix-like OSes.
I'm happy to see a PR to work well on Windows, though!

@QingyaoLin
Copy link
Author

Have you installed all the add-ons (check here what's needed)?

I have installed all the add-ons.

Also note that this repo is for developing rustc-dev-guide and it mainly happens on Unix-like OSes.

This is kind of bad. When people who don't have a Unix-like system want to contribute, they won't be able to see the actual build results.

As I said in QingyaoLin:update-rustc-dev-guide-book, I don't know what happened in the middle and why the link was not detected as invalid.

@JohnTitor
Copy link
Member

Well, I haven't said that we don't welcome contributors outside of Unix 😓
Feel free to send a patch to fix that issue :)

@QingyaoLin
Copy link
Author

QingyaoLin commented Jan 11, 2025

I am not familiar with github CI and need other contributors to try to solve this problem. I will try my best to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug O-windows Operating system: Windows WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Development

No branches or pull requests

4 participants
@JohnTitor @jieyouxu @QingyaoLin and others