Update the minimum external LLVM to 18 #130487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu Some changes occurred in coverage tests. cc @Zalathar This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
This comment was marked as resolved.
This comment was marked as resolved.
cuviper
force-pushed
the
min-llvm-18
branch
from
3e9cede
to
ad18186
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cuviper
force-pushed
the
min-llvm-18
branch
3 times, most recently
from
acffa7f
to
3ecf8e9
Compare
2 tasks
|
Can also remove this hack? rust/library/proc_macro/src/bridge/buffer.rs Lines 122 to 123 in f6bcd09 r=me otherwise |
bors
added
S-waiting-on-bors
cuviper
added
the
relnotes
3 tasks
|
Hack revert LGTM |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 18, 2024
Update the minimum external LLVM to 18 With this change, we'll have stable support for LLVM 18 and 19. For reference, the previous increase to LLVM 17 was rust-lang#122649. cc `@rust-lang/wg-llvm` r? nikic
cuviper
force-pushed
the
min-llvm-18
branch
from
69350a4
to
8bab397
Compare
|
Rebased to solve the merge conflict. @bors r=nikic |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#97524 (Add `Thread::{into_raw, from_raw}`) - rust-lang#127988 (Do not ICE with incorrect empty suggestion) - rust-lang#129422 (Gate `repr(Rust)` correctly on non-ADT items) - rust-lang#129934 (Win: Open dir for sync access in remove_dir_all) - rust-lang#130450 (Reduce confusion about `make_indirect_byval` by renaming it) - rust-lang#130476 (Implement ACP 429: add `Lazy{Cell,Lock}::get[_mut]` and `force_mut`) - rust-lang#130487 (Update the minimum external LLVM to 18) - rust-lang#130513 (Clarify docs for std::fs::File::write) - rust-lang#130522 ([Clippy] Swap `manual_retain` to use diagnostic items instead of paths) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
Rollup merge of rust-lang#130487 - cuviper:min-llvm-18, r=nikic Update the minimum external LLVM to 18 With this change, we'll have stable support for LLVM 18 and 19. For reference, the previous increase to LLVM 17 was rust-lang#122649. cc `@rust-lang/wg-llvm` r? nikic
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 19, 2024
Support 128-bit atomics on s390x Since LLVM 18 (llvm/llvm-project@c568927), 128-bit atomics are fully supported on s390x. And the current minimum external LLVM version is now 18 (rust-lang#130487). s390x 128-bit atomic instructions (lpq,stpq,cdsg) has been present since [the First Edition of the Principles of Operation](https://publibfp.dhe.ibm.com/epubs/pdf/dz9zr000.pdf). (LLVM's minimal supported architecture level [is z10 (the Eighth Edition of the PoP)](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZProcessors.td#L16-L17).) cc rust-lang#99069 r? `@cuviper`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
Rollup merge of rust-lang#130558 - taiki-e:s390x-atomic-128, r=cuviper Support 128-bit atomics on s390x Since LLVM 18 (llvm/llvm-project@c568927), 128-bit atomics are fully supported on s390x. And the current minimum external LLVM version is now 18 (rust-lang#130487). s390x 128-bit atomic instructions (lpq,stpq,cdsg) has been present since [the First Edition of the Principles of Operation](https://publibfp.dhe.ibm.com/epubs/pdf/dz9zr000.pdf). (LLVM's minimal supported architecture level [is z10 (the Eighth Edition of the PoP)](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZProcessors.td#L16-L17).) cc rust-lang#99069 r? `@cuviper`
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Oct 11, 2024
…henkov coverage: Remove code related to LLVM 17 In-tree LLVM is 19, and the minimum external LLVM was increased to 18 in rust-lang#130487.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
Rollup merge of rust-lang#131543 - Zalathar:goodbye-llvm-17, r=petrochenkov coverage: Remove code related to LLVM 17 In-tree LLVM is 19, and the minimum external LLVM was increased to 18 in rust-lang#130487.
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we'll have stable support for LLVM 18 and 19.
For reference, the previous increase to LLVM 17 was #122649.
cc @rust-lang/wg-llvm
r? nikic