Fix some minor issues from the ui-test auto-porting #125030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
approved these changes
May 11, 2024
There was a problem hiding this comment.
I would just re-wrap those comments to suppress the tidy errors. r=me unless you want a review specifically from @jieyouxu.
saethlin
force-pushed
the
ui-test-false-positives
branch
from
333c1bc to
f11bd7e
Compare
|
Hunh. Odd that check runs so late if it's just from tidy. I'll send it if CI passes, thanks! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 12, 2024
…r=compiler-errors Fix some minor issues from the ui-test auto-porting I'm not sure if these count as false positives, because well, starting a comment with `// incremental` was probably a valid compiletest directive. But anyway, these tests directives became clearly goofy and now with the better syntax we can straighten things out. r? jieyouxu
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#124807 (Migrate `run-make/rustdoc-io-error` to `rmake.rs`) - rust-lang#125021 (Update reference safety requirements) - rust-lang#125030 (Fix some minor issues from the ui-test auto-porting) - rust-lang#125036 (solve: all "non-structural" logging to trace) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#125021 (Update reference safety requirements) - rust-lang#125022 (Migrate rustdoc scrape examples ordering) - rust-lang#125030 (Fix some minor issues from the ui-test auto-porting) - rust-lang#125036 (solve: all "non-structural" logging to trace) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2024
Rollup merge of rust-lang#125030 - saethlin:ui-test-false-positives, r=compiler-errors Fix some minor issues from the ui-test auto-porting I'm not sure if these count as false positives, because well, starting a comment with `// incremental` was probably a valid compiletest directive. But anyway, these tests directives became clearly goofy and now with the better syntax we can straighten things out. r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if these count as false positives, because well, starting a comment with
// incrementalwas probably a valid compiletest directive.But anyway, these tests directives became clearly goofy and now with the better syntax we can straighten things out.
r? jieyouxu