Skip to content

Commit

Permalink
Unrolled build for rust-lang#125030
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#125030 - saethlin:ui-test-false-positives, r=compiler-errors

Fix some minor issues from the ui-test auto-porting

I'm not sure if these count as false positives, because well, starting a comment with `// incremental` was probably a valid compiletest directive.

But anyway, these tests directives became clearly goofy and now with the better syntax we can straighten things out.

r? jieyouxu
  • Loading branch information
rust-timer authored May 12, 2024
2 parents b71fa82 + f11bd7e commit 2bb00d9
Show file tree
Hide file tree
Showing 14 changed files with 13 additions and 38 deletions.
5 changes: 1 addition & 4 deletions tests/codegen-units/partitioning/extern-drop-glue.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
//

// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
// We specify opt-level=0 because `drop_in_place` is `Internal` when optimizing
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
Expand Down
4 changes: 1 addition & 3 deletions tests/codegen-units/partitioning/extern-generic.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=eager -Zshare-generics=y

Expand Down
3 changes: 1 addition & 2 deletions tests/codegen-units/partitioning/incremental-merging.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Ccodegen-units=3
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Zinline-in-all-cgus
Expand Down
4 changes: 1 addition & 3 deletions tests/codegen-units/partitioning/local-drop-glue.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
// We specify opt-level=0 because `drop_in_place` is `Internal` when optimizing
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
Expand Down
3 changes: 1 addition & 2 deletions tests/codegen-units/partitioning/local-generic.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=eager

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Zinline-in-all-cgus=no
Expand Down
4 changes: 1 addition & 3 deletions tests/codegen-units/partitioning/local-inlining.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Zinline-in-all-cgus
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Zinline-in-all-cgus
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
// much sense at the moment.
//@ ignore-test

//
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy

Expand Down
3 changes: 1 addition & 2 deletions tests/codegen-units/partitioning/regular-modules.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=eager

Expand Down
1 change: 0 additions & 1 deletion tests/codegen-units/partitioning/shared-generics.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//
//@ no-prefer-dynamic
// NOTE: We always compile this test with -Copt-level=0 because higher opt-levels
// prevent drop-glue from participating in share-generics.
Expand Down
3 changes: 1 addition & 2 deletions tests/codegen-units/partitioning/statics.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy

Expand Down
5 changes: 1 addition & 4 deletions tests/codegen-units/partitioning/vtable-through-const.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
//

// We specify incremental here because we want to test the partitioning for
//@ incremental compilation
// We specify incremental here because we want to test the partitioning for incremental compilation
//@ incremental
//@ compile-flags:-Zprint-mono-items=lazy
//@ compile-flags:-Zinline-in-all-cgus
Expand Down

0 comments on commit 2bb00d9

Please sign in to comment.