Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen tests: Tolerate nuw nsw on trunc #123808

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Apr 11, 2024

llvm/llvm-project#87910 infers nuw and nsw on some trunc instructions we're doing FileCheck on. Tolerate but don't require them to support both release and head LLVM.

@rustbot label: +llvm-main

cc @durin42

llvm/llvm-project#87910 infers `nuw` and `nsw` on some `trunc`
instructions we're doing `FileCheck` on. Tolerate but don't require them
to support both release and head LLVM.
@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Apr 11, 2024
@durin42
Copy link
Contributor

durin42 commented Apr 11, 2024

Oh nice, that's easier to fix than I was afraid of.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit e70cf01 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123459 (Correctly handle inlining of doc hidden foreign items)
 - rust-lang#123740 (Reduce Size of `ModifierInfo`)
 - rust-lang#123770 (Correct broken link in core::pin doc)
 - rust-lang#123777 (Deduplicate some function implementations between the parser and AST/HIR)
 - rust-lang#123808 (codegen tests: Tolerate `nuw` `nsw` on `trunc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a710de9 into rust-lang:master Apr 11, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
Rollup merge of rust-lang#123808 - maurer:nuw-nsw-trunc, r=durin42

codegen tests: Tolerate `nuw` `nsw` on `trunc`

llvm/llvm-project#87910 infers `nuw` and `nsw` on some `trunc` instructions we're doing `FileCheck` on. Tolerate but don't require them to support both release and head LLVM.

`@rustbot` label: +llvm-main

cc `@durin42`
@rustbot rustbot added this to the 1.79.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants