Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct broken link in core::pin doc #123770

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Correct broken link in core::pin doc #123770

merged 1 commit into from
Apr 11, 2024

Conversation

tomokinat
Copy link
Contributor

This is a minor correction to the doc, which fails to link Unpin trait.

Before (rendered):
before

After (rendered):
before

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 11, 2024
@joboet
Copy link
Contributor

joboet commented Apr 11, 2024

Thank you!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit 68914f2 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2024
@joboet joboet assigned joboet and unassigned Amanieu Apr 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@bors
Auto merge of rust-lang#123814 - matthiaskrgr:rollup-lxn0t4t, r=matth…
616a8f8 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123459 (Correctly handle inlining of doc hidden foreign items)
 - rust-lang#123740 (Reduce Size of `ModifierInfo`)
 - rust-lang#123770 (Correct broken link in core::pin doc)
 - rust-lang#123777 (Deduplicate some function implementations between the parser and AST/HIR)
 - rust-lang#123808 (codegen tests: Tolerate `nuw` `nsw` on `trunc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6625b75 into rust-lang:master Apr 11, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@rust-timer
Unrolled build for rust-lang#123770
28ffa9a 
Rollup merge of rust-lang#123770 - tomokinat:master, r=joboet

Correct broken link in core::pin doc

This is a minor correction to the doc, which fails to link `Unpin` trait.

Before (rendered):
![before](https://github.com/rust-lang/rust/assets/49511064/c4f2f94d-91ea-4cee-be69-b0053453194a)

After (rendered):
![before](https://github.com/rust-lang/rust/assets/49511064/847068f8-73b2-4acb-ab78-3351ffe5b0a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tomokinat @rustbot @joboet @bors @Amanieu