unix fs: Make hurd using explicit new rather than From #123057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
|
cc @leo60228 @jam1garner Should the Horizon targets get the same fix here? |
|
r=me with that concern resolved ^^ |
|
@workingjubilee I think you meant to ping the |
|
oops. |
|
@leo60228 Thanks, sorry about that! |
workingjubilee
added
the
beta-nominated
|
re: beta-nominated: The relevant breaking commit has crept into the beta, as I noted here: #123032 (comment) This will fix the stdlib build for Debian Hurd, which is supposed to use the stable branch, per the policy cited by @sthibaul: #123032 (comment) It seems fairly harmless to backport this. |
|
Hi, thanks for the ping! I just double checked and yes, this fix would also apply for |
Noratrieb
reviewed
Mar 26, 2024
408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd and horizon builds. Fixes rust-lang#123032
|
I updated the change to include horizon too. |
ian-h-chamberlain
approved these changes
Mar 26, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 26, 2024
unix fs: Make hurd using explicit new rather than From 408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd build (and probably the horizon build) Fixes rust-lang#123032
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108675 (Document `adt_const_params` feature in Unstable Book) - rust-lang#122120 (Suggest associated type bounds on problematic associated equality bounds) - rust-lang#122589 (Fix diagnostics for async block cloning) - rust-lang#122835 (Require `DerefMut` and `DerefPure` on `deref!()` patterns when appropriate) - rust-lang#123049 (In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer) - rust-lang#123055 (enable cargo miri test doctests) - rust-lang#123057 (unix fs: Make hurd using explicit new rather than From) - rust-lang#123087 (Change `f16` and `f128` clippy stubs to be nonpanicking) - rust-lang#123103 (Rename `Inherited` -> `TypeckRootCtxt`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2024
Rollup merge of rust-lang#123057 - sthibaul:systemtime, r=jhpratt unix fs: Make hurd using explicit new rather than From 408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd build (and probably the horizon build) Fixes rust-lang#123032
m-ou-se
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
Amanieu
added
the
beta-nominated
|
@Amanieu, we (T-release) deliberately remove "nominated" labels once a PR has been added to a backport PR. |
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2024
[beta] backports - Fix f16 and f128 feature gates in editions other than 2015 rust-lang#123307 / rust-lang#123445 - Update to LLVM 18.1.2 rust-lang#122772 - unix fs: Make hurd using explicit new rather than From rust-lang#123057 - Don't inherit codegen attrs from parent static rust-lang#123310 - Make sure to insert Sized bound first into clauses list rust-lang#123302 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
[beta] backports - Fix f16 and f128 feature gates in editions other than 2015 rust-lang#123307 / rust-lang#123445 - Update to LLVM 18.1.2 rust-lang#122772 - unix fs: Make hurd using explicit new rather than From rust-lang#123057 - Don't inherit codegen attrs from parent static rust-lang#123310 - Make sure to insert Sized bound first into clauses list rust-lang#123302 r? cuviper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd build (and probably the horizon build)
Fixes #123032