Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document adt_const_params feature in Unstable Book #108675

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Document adt_const_params feature in Unstable Book #108675

merged 1 commit into from
Mar 27, 2024

Conversation

Shadlock0133
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2023
@GuillaumeGomez
Copy link
Member

r? rust-lang/compiler

@BoxyUwU
Copy link
Member

BoxyUwU commented Mar 2, 2023

there's already an entry for this with underscores instead of hyphens, but its pretty empty 😅

@compiler-errors
Copy link
Member

r? @BoxyUwU feel free to reassign to me tho

@rustbot rustbot assigned BoxyUwU and unassigned compiler-errors Mar 7, 2023
@anden3 anden3 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023
@tranquillity-codes tranquillity-codes added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2024
@Dylan-DPC
Copy link
Member

r? compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned BoxyUwU Feb 9, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2024

📌 Commit 69e5d7d has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#108675 - Shadlock0133:adt_const_params, r=c…
27a1c56 
…ompiler-errors

Document `adt_const_params` feature in Unstable Book
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2024
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in
#120977 (comment)
https://github.com/rust-lang/rust/actions/runs/7874596749/job/21484572859#step:26:6143

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2024
@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 12, 2024

we already ahve an entry for adt_const_params iirc

@compiler-errors
Copy link
Member

compiler-errors commented Feb 12, 2024 •
edited
Loading

@BoxyUwU: I cannot find it 🤔

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 13, 2024

https://doc.rust-lang.org/unstable-book/language-features/adt-const-params.html (?) unless im misunderstanding waht this PR does

@Dylan-DPC Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2024

📌 Commit 17ba73c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 26, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 26, 2024
@workingjubilee
Rollup merge of rust-lang#108675 - Shadlock0133:adt_const_params, r=c…
d7df149 
…ompiler-errors

Document `adt_const_params` feature in Unstable Book
@workingjubilee workingjubilee mentioned this pull request Mar 26, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2024
@bors
Auto merge of rust-lang#123108 - matthiaskrgr:rollup-zossklv, r=matth…
a1b4991 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108675 (Document `adt_const_params` feature in Unstable Book)
 - rust-lang#122120 (Suggest associated type bounds on problematic associated equality bounds)
 - rust-lang#122589 (Fix diagnostics for async block cloning)
 - rust-lang#122835 (Require `DerefMut` and `DerefPure` on `deref!()` patterns when appropriate)
 - rust-lang#123049 (In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer)
 - rust-lang#123055 (enable cargo miri test doctests)
 - rust-lang#123057 (unix fs: Make hurd using explicit new rather than From)
 - rust-lang#123087 (Change `f16` and `f128` clippy stubs to be nonpanicking)
 - rust-lang#123103 (Rename `Inherited` -> `TypeckRootCtxt`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9162776 into rust-lang:master Mar 27, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2024
@rust-timer
Unrolled build for rust-lang#108675
ef5e401 
Rollup merge of rust-lang#108675 - Shadlock0133:adt_const_params, r=compiler-errors

Document `adt_const_params` feature in Unstable Book
@Shadlock0133 Shadlock0133 deleted the adt_const_params branch March 27, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.