Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move platform modules into sys::pal #117285

Merged
merged 13 commits into from
Jan 13, 2024
Merged

Move platform modules into sys::pal #117285

merged 13 commits into from
Jan 13, 2024

Conversation

joboet
Copy link
Member

@joboet joboet commented Oct 27, 2023

This is the initial step of #117276. sys just re-exports everything from the current sys for now, I'll move the implementations for the individual features one-by-one after this PR merges.

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 27, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2023

The Miri subtree was changed

cc @rust-lang/miri

@joboet joboet mentioned this pull request Oct 27, 2023
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 28, 2023

☔ The latest upstream changes (presumably #117309) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 30, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2023

The Miri subtree was changed

cc @rust-lang/miri

These commits modify compiler targets.
(See the Target Tier Policy.)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung mentioned this pull request Oct 30, 2023
Open
@bors
Copy link
Contributor

bors commented Nov 1, 2023

☔ The latest upstream changes (presumably #117459) made this pull request unmergeable. Please resolve the merge conflicts.

@joboet joboet marked this pull request as draft November 1, 2023 12:02
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@joboet joboet force-pushed the move_platforms_to_pal branch 2 times, most recently from ac08433 to db1cbc7 Compare November 21, 2023 15:42
@joboet
Copy link
Member Author

joboet commented Nov 21, 2023 •
edited
Loading

I've completely rewritten this PR, separating moves and changes, and kept all the comment-editing out, as those will need to be adjusted anyway in the PRs to come.

@rustbot ready

@joboet joboet marked this pull request as ready for review November 21, 2023 17:39
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2023
@bors
Copy link
Contributor

bors commented Nov 23, 2023

☔ The latest upstream changes (presumably #118154) made this pull request unmergeable. Please resolve the merge conflicts.

@joboet
Copy link
Member Author

joboet commented Jan 11, 2024

As this PR is very likely to bitrot and I'd like to avoid rebasing it every few days, I'm going to leave it in the current state for now. If you'd like to start reviewing it, let me know and I'll update it.

@ChrisDenton ChrisDenton assigned ChrisDenton and unassigned thomcc Jan 11, 2024
@ChrisDenton
Copy link
Member

@joboet If you rebase, I'll review this as soon as I'm able.

This was referenced Jan 13, 2024
Closed
Open
Merged
Closed
Merged
Merged
Merged
Open
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Open
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d8d7b1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [1.9%, 2.8%] 2
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -2.1% [-2.3%, -2.0%] 3
Improvements ✅
(secondary)		 -2.8% [-3.5%, -2.2%] 2
All ❌✅ (primary) -0.3% [-2.3%, 2.8%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.4%, -1.8%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.206s -> 669.329s (0.02%)
Artifact size: 308.17 MiB -> 308.19 MiB (0.00%)

@joboet joboet mentioned this pull request Jan 13, 2024
Merged
@joboet joboet deleted the move_platforms_to_pal branch January 13, 2024 17:43
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#119935 - joboet:move_pal_personality, r=Chr…
3a33a4b 
…isDenton

Move personality implementation out of PAL

The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
@rust-timer
Unrolled build for rust-lang#119935
7c81f0c 
Rollup merge of rust-lang#119935 - joboet:move_pal_personality, r=ChrisDenton

Move personality implementation out of PAL

The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

Assignees

@ChrisDenton ChrisDenton

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
9 participants
@joboet @rustbot @rust-log-analyzer @bors @ChrisDenton @rust-timer @klensy @thomcc @Dylan-DPC