Tracking Issue for restructuring `std::sys` #117276

joboet · 2023-10-27T11:09:17Z

On Wednesday, the libs-team discussed reorganizing the platform-specific modules inside std, namely sys and sys_common into a new structure. These modules will be merged into one sys module with a feature-first organization:

the submodules of sys, named after the feature they implement, contain all the implementations of the different platforms and provide a uniform interface that the rest of std may depend on. E.g. sys::thread_local, sys::fs or sys::thread_parking.
sys::pal contains platform-specific generic API wrappers like ~~FileDesc~~ cvt (UNIX) used to implement these features. E.g. sys::pal::unix, sys::pal::windows or (perhaps) sys::pal::apple.

The rest of std, modulo std::os, should now only depend on sys::feature_name and not sys::pal. The implementations themselves may however depend on other parts of std as necessary.

Tasks

Give feedback

Move platform modules into sys::pal #117285

A-meta A-testsuite S-waiting-on-bors T-bootstrap T-compiler T-libs merged-by-bors
Move personality implementation out of PAL #119935

A-testsuite S-waiting-on-bors T-bootstrap T-libs
Move OS String implementation into sys #119996

O-SGX O-hermit O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs
Move cmath into sys #120109

O-SGX O-hermit O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs
Move path implementations into sys #120776

O-SGX O-hermit O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs
Move locks to sys #121177

A-meta O-SGX O-hermit O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs merged-by-bors
Move thread local implementation to sys #121758

S-waiting-on-bors T-libs
Move Once implementations to sys #122386

A-meta O-wasi O-wasm S-waiting-on-bors T-libs
Remove sys_common::thread #123807

S-waiting-on-bors T-libs
Move thread parking to sys::sync #124159

O-SGX O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs
std: refactor the TLS implementation #126523

A-thread-locals O-SGX O-hermit O-itron O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs merged-by-bors
std: move sys_common::backtrace to sys #126546

S-waiting-on-bors T-libs
std: move allocators to sys #128134

O-SGX O-hermit O-solid O-unix O-wasi O-wasm O-windows S-waiting-on-bors T-libs merged-by-bors
Move remaining features from sys_common and sys::pal into sys
Options

@rustbot label +T-libs +E-help-wanted
@rustbot claim

The text was updated successfully, but these errors were encountered:

…sDenton Move platform modules into `sys::pal` This is the initial step of rust-lang#117276. `sys` just re-exports everything from the current `sys` for now, I'll move the implementations for the individual features one-by-one after this PR merges.

…isDenton Move personality implementation out of PAL The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.

Rollup merge of rust-lang#119935 - joboet:move_pal_personality, r=ChrisDenton Move personality implementation out of PAL The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.

Move OS String implementation into `sys` Part of rust-lang#117276. The new structure is really useful here, since we can easily eliminate a number of ugly `#[path]`-based imports. In the future, it might be good to move the WTF-8 implementation directly to the OS string implementation, I cannot see it being used anywhere else. That is a story for another PR, however.

Rollup merge of rust-lang#119996 - joboet:move_pal_os_str, r=ChrisDenton Move OS String implementation into `sys` Part of rust-lang#117276. The new structure is really useful here, since we can easily eliminate a number of ugly `#[path]`-based imports. In the future, it might be good to move the WTF-8 implementation directly to the OS string implementation, I cannot see it being used anywhere else. That is a story for another PR, however.

ChrisDenton · 2024-01-22T09:07:38Z

Something that just occurred to me is that we might want to add commits to https://github.com/rust-lang/rust/blob/master/.git-blame-ignore-revs if they're purely moving files. This allows GitHub's blame interface to ignore them.

Move cmath into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

Move locks to `sys` Part of rust-lang#117276. r? `@ChrisDenton`

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=ChrisDenton Move thread local implementation to `sys` Part of rust-lang#117276.

Move `Once` implementations to `sys` Part of rust-lang#117276.

Rollup merge of rust-lang#122386 - joboet:move_pal_once, r=jhpratt Move `Once` implementations to `sys` Part of rust-lang#117276.

Remove `sys_common::thread` Part of rust-lang#117276. The stack size calculation isn't system-specific at all and can just live together with the rest of the spawn logic.

Rollup merge of rust-lang#123807 - joboet:sys_common_thread, r=jhpratt Remove `sys_common::thread` Part of rust-lang#117276. The stack size calculation isn't system-specific at all and can just live together with the rest of the spawn logic.

…ChrisDenton Move thread parking to `sys::sync` Part of rust-lang#117276. I'll leave the platform-specific API abstractions in `sys::pal`, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen. r? `@ChrisDenton` (if you have time)

…ChrisDenton Move thread parking to `sys::sync` Part of rust-lang#117276. I'll leave the platform-specific API abstractions in `sys::pal`, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen. r? ``@ChrisDenton`` (if you have time)

Rollup merge of rust-lang#124159 - joboet:move_pal_thread_parking, r=ChrisDenton Move thread parking to `sys::sync` Part of rust-lang#117276. I'll leave the platform-specific API abstractions in `sys::pal`, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen. r? ``@ChrisDenton`` (if you have time)

@rustbot

As discovered by Mara in rust-lang#110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with rust-lang#117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` functions to the `thread_local` module in `sys` and given them a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`. Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones: * the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code. * I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps. @rustbot label +A-thread-locals

@rustbot

As discovered by Mara in rust-lang#110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with rust-lang#117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` modules to the `thread_local` module in `sys` and merged them into a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`. Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones: * the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code. * I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps. @rustbot label +A-thread-locals

…ngjubilee std: move `sys_common::backtrace` to `sys` Part of rust-lang#117276.

Rollup merge of rust-lang#126546 - joboet:move_pal_backtrace, r=workingjubilee std: move `sys_common::backtrace` to `sys` Part of rust-lang#117276.

… r=Mark-Simulacrum std: refactor the TLS implementation As discovered by Mara in rust-lang#110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with rust-lang#117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` modules to the `thread_local` module in `sys` and merged them into a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`. Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones: * the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code. * I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps. `@rustbot` label +A-thread-locals

…=Mark-Simulacrum std: refactor the TLS implementation As discovered by Mara in rust-lang#110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with rust-lang#117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` modules to the `thread_local` module in `sys` and merged them into a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`. Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones: * the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code. * I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps. `@rustbot` label +A-thread-locals

std: move allocators to `sys` Part of rust-lang#117276.

joboet added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Oct 27, 2023

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 27, 2023

rustbot assigned joboet Oct 27, 2023

joboet mentioned this issue Oct 27, 2023

Move platform modules into sys::pal #117285

Merged

joboet mentioned this issue Nov 24, 2023

Move futex locks to sys_common #104329

Closed

joboet mentioned this issue Jan 13, 2024

Move personality implementation out of PAL #119935

Merged

This was referenced Jan 15, 2024

Move OS String implementation into sys #119996

Merged

Move cmath into sys #120109

Merged

rustbot added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jan 18, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2024

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton

dae6d2a

Move cmath into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2024

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton

42e1db5

Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 23, 2024

Unrolled build for rust-lang#120109

24e97e7

Rollup merge of rust-lang#120109 - joboet:move_pal_cmath, r=ChrisDenton Move cmath into `sys` Part of rust-lang#117276. r? ``@ChrisDenton``

joboet mentioned this issue Feb 8, 2024

Move path implementations into sys #120776

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton

434f080

Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 9, 2024

Unrolled build for rust-lang#120776

27696f4

Rollup merge of rust-lang#120776 - joboet:move_pal_path, r=ChrisDenton Move path implementations into `sys` Part of rust-lang#117276. r? `@ChrisDenton`

joboet mentioned this issue Feb 16, 2024

Move locks to sys #121177

Merged

bors added a commit to rust-lang-ci/rust that referenced this issue Feb 19, 2024

Auto merge of rust-lang#121177 - joboet:move_pal_locks, r=ChrisDenton

ccb1415

Move locks to `sys` Part of rust-lang#117276. r? `@ChrisDenton`

joboet mentioned this issue Feb 28, 2024

Move thread local implementation to sys #121758

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

9a213c6

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

26bac2a

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 2, 2024

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=Ch…

2f72206

…risDenton Move thread local implementation to `sys` Part of rust-lang#117276.

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 2, 2024

Unrolled build for rust-lang#121758

ea55f8c

Rollup merge of rust-lang#121758 - joboet:move_pal_thread_local, r=ChrisDenton Move thread local implementation to `sys` Part of rust-lang#117276.

joboet mentioned this issue Mar 12, 2024

Tracking Issue for restructuring sys_common #84187

Closed

joboet mentioned this issue Mar 12, 2024

Move Once implementations to sys #122386

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2024

Rollup merge of rust-lang#122386 - joboet:move_pal_once, r=jhpratt

a269306

Move `Once` implementations to `sys` Part of rust-lang#117276.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 13, 2024

Rollup merge of rust-lang#122386 - joboet:move_pal_once, r=jhpratt

dff680d

Move `Once` implementations to `sys` Part of rust-lang#117276.

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 13, 2024

Unrolled build for rust-lang#122386

1d74445

Rollup merge of rust-lang#122386 - joboet:move_pal_once, r=jhpratt Move `Once` implementations to `sys` Part of rust-lang#117276.

joboet mentioned this issue Apr 11, 2024

Remove sys_common::thread #123807

Merged

joboet mentioned this issue Apr 19, 2024

Move thread parking to sys::sync #124159

Merged

joboet mentioned this issue Jun 15, 2024

std: refactor the TLS implementation #126523

Merged

joboet mentioned this issue Jun 16, 2024

std: move sys_common::backtrace to sys #126546

Merged

jieyouxu added a commit to jieyouxu/rust that referenced this issue Jun 16, 2024

Rollup merge of rust-lang#126546 - joboet:move_pal_backtrace, r=worki…

b2e34b1

…ngjubilee std: move `sys_common::backtrace` to `sys` Part of rust-lang#117276.

rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 16, 2024

Unrolled build for rust-lang#126546

4faf611

Rollup merge of rust-lang#126546 - joboet:move_pal_backtrace, r=workingjubilee std: move `sys_common::backtrace` to `sys` Part of rust-lang#117276.

joboet mentioned this issue Jul 3, 2024

Guard against calling libc::exit multiple times on Linux. #126606

Merged

joboet mentioned this issue Jul 24, 2024

std: move allocators to sys #128134

Merged

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 27, 2024

Auto merge of rust-lang#128134 - joboet:move_pal_alloc, r=cuviper

53e666d

std: move allocators to `sys` Part of rust-lang#117276.

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 27, 2024

Auto merge of rust-lang#128134 - joboet:move_pal_alloc, r=cupiver

787782c

std: move allocators to `sys` Part of rust-lang#117276.

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 27, 2024

Auto merge of rust-lang#128134 - joboet:move_pal_alloc, r=cupiver

600edc9

std: move allocators to `sys` Part of rust-lang#117276.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking Issue for restructuring `std::sys` #117276

Tracking Issue for restructuring `std::sys` #117276

joboet commented Oct 27, 2023 •

edited

Loading

Tasks

ChrisDenton commented Jan 22, 2024

Tracking Issue for restructuring std::sys #117276

Tracking Issue for restructuring std::sys #117276

Comments

joboet commented Oct 27, 2023 • edited Loading

Tasks

ChrisDenton commented Jan 22, 2024

Tracking Issue for restructuring `std::sys` #117276

Tracking Issue for restructuring `std::sys` #117276

joboet commented Oct 27, 2023 •

edited

Loading