adjust how closure/generator types are printed #115696
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hm, something somewhere is still printing |
|
Ah, what I changed was actually the rvalue printing (which doesn't seem to be exercised by the test suite), not the type printing. |
RalfJung
force-pushed
the
closure-ty-print
branch
from
d9d80be
to
2771839
Compare
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
RalfJung
force-pushed
the
closure-ty-print
branch
from
2771839
to
411e645
Compare
|
Seems fine to me, please create an MCP for it so all of the compiler team gets informed about it. |
|
☔ The latest upstream changes (presumably #115661) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@oli-obk how long do we want to wait from the MCP seconding to landing the PR? |
RalfJung
force-pushed
the
closure-ty-print
branch
from
411e645
to
aa50cde
Compare
|
MCPs are 10 days |
|
☔ The latest upstream changes (presumably #115865) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
added
the
relnotes
|
the MCP has been accepted for 10 days now this can be merged after a rebase presumably |
RalfJung
force-pushed
the
closure-ty-print
branch
from
aa50cde
to
c4ec12f
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (959b2c7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.528s -> 635.567s (0.32%) |
adjust how closure/generator types are printed I saw `&[closure@$DIR/issue-20862.rs:2:5]` and I thought it is a slice type, because that's usually what `&[_]` is... it took me a while to realize that this is just a confusing printer and actually there's no slice. Let's use something that cannot be mistaken for a regular type.
I saw
&[closure@$DIR/issue-20862.rs:2:5]and I thought it is a slice type, because that's usually what&[_]is... it took me a while to realize that this is just a confusing printer and actually there's no slice. Let's use something that cannot be mistaken for a regular type.