Change how closure and generator types are printed to avoid clash with slice types

[RalfJung]

Proposal

When the compiler has to print the type of a closure or generator, it currently looks like this: [closure@$DIR/issue-20862.rs:2:5]. The choice of using brackets here is unfortunate, since it means a reference-to-closure &[closure@$DIR/issue-20862.rs:2:5] looks like a slice type! I was quite confused by this recently.

Hence I propose we change this to use curly braces instead, which don't already have a meaning as types: &{closure@$DIR/issue-20862.rs:2:5}.

This has been implemented in rust-lang/rust#115696.

Mentors or Reviewers

@oli-obk

Process

The main points of the Major Change Process are as follows:

• File an issue describing the proposal.
• A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
  • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
  • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
• Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

[rustbot]

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

[oli-obk]

@rustbot second

[apiraino]

@rustbot label -final-comment-period +major-change-accepted