Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #115553

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Rollup of 5 pull requests #115553

merged 10 commits into from
Sep 5, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Enselic and others added 10 commits August 30, 2023 20:43
@Enselic
Emit error instead of ICE when optimized MIR is missing
456007a 
Closes 51388.
@Jarcho
Take &mut Results in ResultsVisitor
f686bd8
@Enselic
Allow large_assignments for Box/Arc/Rc initialization
789451b 
Does the `stop linting in box/arc initialization` task of 83518.
@compiler-errors
Don't ICE on associated type projection without feature gate
8c667fe
@ouz-a
provide more useful info for DefId Debug
56d10a8
@matthiaskrgr
Rollup merge of rust-lang#115353 - Enselic:no-optimized-mir, r=oli-obk
a73c663 
Emit error instead of ICE when optimized MIR is missing

Closes rust-lang#51388
@matthiaskrgr
Rollup merge of rust-lang#115488 - Jarcho:mut_result_visitor, r=oli-obk
e9d15ec 
Take `&mut Results` in `ResultsVisitor`

This fixes a small oversight from rust-lang#108293.
@matthiaskrgr
Rollup merge of rust-lang#115492 - Enselic:large-box-move, r=oli-obk
6f180ea 
Allow `large_assignments` for Box/Arc/Rc initialization

Does the `stop linting in box/arc initialization` task of rust-lang#83518.

r? `@oli-obk` who is E-mentor.
@matthiaskrgr
Rollup merge of rust-lang#115519 - compiler-errors:next-solver-assoc-…
f5e6aa3 
…ice, r=lcnr

Don't ICE on associated type projection without feature gate in new solver

Self-explanatory, we should avoid ICEs when the feature gate is not enabled. Continue to ICE when the feature gate *is* enabled, though.

Fixes rust-lang#115500
@matthiaskrgr
Rollup merge of rust-lang#115534 - ouz-a:smir_def, r=oli-obk
03853d5 
Expose more information with DefId in smir

Currently `Debug` for `DefId` doesn't provide enough information, this changes so that we get `usize` of the `DefId` and the name of it.

r? `@oli-obk`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Sep 5, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Sep 5, 2023

📌 Commit 03853d5 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit 03853d5 with merge 8cfaf70...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8cfaf70 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2023
@bors bors merged commit 8cfaf70 into rust-lang:master Sep 5, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 5, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#115353 Emit error instead of ICE when optimized MIR is missing bdefa46ac392584c4b020e68fd53ff71a37d9a81 (link)
#115488 Take &mut Results in ResultsVisitor d7a542533bf808632e69f9859242b39c20dddba9 (link)
#115492 Allow large_assignments for Box/Arc/Rc initialization 597c5358cc3bd594ffc2eb22ac18549bb8225735 (link)
#115519 Don't ICE on associated type projection without feature gat… c220c9b1d988a48065a555ea22e626571d1b67a7 (link)
#115534 Expose more information with DefId in smir 52982d1538a11ee6e12db07368ce626afee69fc7 (link)

previous master: 626a6ab93f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Sep 5, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8cfaf70): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.8%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.8%] 6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 1.8% [0.8%, 3.2%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.0% [-1.6%, -0.8%] 3
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.535s -> 628.68s (0.18%)
Artifact size: 316.30 MiB -> 316.31 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 5, 2023
@lqd
Copy link
Member

lqd commented Sep 5, 2023

Looks like libc-0.2.124 noise 🤔

@pnkfelix
Copy link
Member

pnkfelix commented Sep 5, 2023

  • believe to be spurious, marking as triaged

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 5, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-c0045hz branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-timer @lqd @pnkfelix @rustbot @Enselic @Jarcho @compiler-errors @ouz-a