Expose more information with DefId in smir #115534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
oli-obk
reviewed
Sep 4, 2023
| @@ -37,9 +37,14 @@ impl<'tcx> Context for Tables<'tcx> { | |||
| }) | |||
| } | |||
|
|
|||
| fn name_of_def_id(&self, def_id: stable_mir::DefId) -> String { | |||
| self.tcx.def_path_str(item_def_id(&CrateItem(def_id))) | |||
There was a problem hiding this comment.
Suggested change
| self.tcx.def_path_str(item_def_id(&CrateItem(def_id))) | |
| self.tcx.def_path_str(self[def_id]) |
oli-obk
reviewed
Sep 4, 2023
| pub struct DefId(pub(crate) usize); | ||
|
|
||
| impl Debug for DefId { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| fmt::Debug::fmt(&format!("id:{} name:{}", self.0, with(|cx| cx.name_of_def_id(*self))), f) |
There was a problem hiding this comment.
please use the Formatter methods for printing structs and their fields.
|
@bors r+ rollup We'll need to do something similar for the other indexed types in the future |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 4, 2023
Expose more information with DefId in smir Currently `Debug` for `DefId` doesn't provide enough information, this changes so that we get `usize` of the `DefId` and the name of it. r? `@oli-obk`
|
⌛ Testing commit 56d10a8 with merge 0a211da0d59a5a4b3df41ba6ce7783fd70099ab7... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry GitHub checkout issue |
bors
added
S-waiting-on-bors
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115353 (Emit error instead of ICE when optimized MIR is missing) - rust-lang#115488 (Take `&mut Results` in `ResultsVisitor`) - rust-lang#115492 (Allow `large_assignments` for Box/Arc/Rc initialization) - rust-lang#115519 (Don't ICE on associated type projection without feature gate in new solver) - rust-lang#115534 (Expose more information with DefId in smir) r? `@ghost` `@rustbot` modify labels: rollup
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 6, 2023
Better Debug for `Ty` in smir Similar to what I did here rust-lang#115534. r? `@oli-obk`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 6, 2023
Better Debug for `Ty` in smir Similar to what I did here rust-lang#115534. r? ``@oli-obk``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
DebugforDefIddoesn't provide enough information, this changes so that we getusizeof theDefIdand the name of it.r? @oli-obk