Return equal for two identical projections #109433
Conversation
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @wesleywiser |
| "we captured two identical projections: capture1 = {:?}, capture2 = {:?}", | ||
| capture1, capture2 | ||
| ); | ||
| // return Equal for two identical projections |
There was a problem hiding this comment.
it looks like this could be a delay_span_bug instead? 🤔
There was a problem hiding this comment.
yes, I will make a change.
There was a problem hiding this comment.
I add delay_span_bug and also keep the std::cmp::Ordering::Equal so that we keep minimal change since we need to return Ordering type for the sort_by function.
|
Keep in mind that the "Partially" word in the PR description has no effect and github will close the issue if this is merged, regardless of the fact that this PR only seems to address part of the issue. |
Thanks for the reminder, I will create another issue for that case in the comment as it is a different issue. |
|
oh, it's my fix make the second test case crash in another place, I will change this PR to WIP and continue work on it. |
|
The root cause is different, so I create another issue #109523 to track it. |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#109406 (Remove outdated comments) - rust-lang#109433 (Return equal for two identical projections) - rust-lang#109495 (Implement non-const `Destruct` trait in new solver) - rust-lang#109519 (Link against libc++ on AIX) - rust-lang#109550 (Make helper functions private in fn_ctxt/adjust_fulfillment_errors) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #109188