Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
WaffleLapkin
commented
Mar 20, 2023
Comment on lines
-1
to
-3
| // This is pretty much entirely stolen from TreeSet, since BTreeMap has an identical interface | ||
| // to TreeMap | ||
|
|
Comment on lines
-21
to
-22
| // FIXME(conventions): implement bounded iterators | ||
|
|
There was a problem hiding this comment.
I think this refers range, which was added. Originated in #18605. Similar comment for map was removed since.
Comment on lines
-15
to
-21
| // Future Optimization (FIXME!) | ||
| // ============================ | ||
| // | ||
| // Iteration over zero sized values is a noop. There is no need | ||
| // for `bucket.val` in the case of HashSet. I suppose we would need HKT | ||
| // to get rid of it properly. | ||
|
|
There was a problem hiding this comment.
This was added way before hashbrown. Now this doesn't make any sense.
|
That all looks fine, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#109406 (Remove outdated comments) - rust-lang#109433 (Return equal for two identical projections) - rust-lang#109495 (Implement non-const `Destruct` trait in new solver) - rust-lang#109519 (Link against libc++ on AIX) - rust-lang#109550 (Make helper functions private in fn_ctxt/adjust_fulfillment_errors) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title said