Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#97995 #99224

Closed
rust-highfive opened this issue Jul 14, 2022 · 3 comments · Fixed by #99283
Closed

miri no longer builds after rust-lang/rust#97995 #99224

rust-highfive opened this issue Jul 14, 2022 · 3 comments · Fixed by #99283
Assignees
@RalfJung @oli-obk
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #97995, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @RalfJung, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Jul 14, 2022
@RalfJung RalfJung mentioned this issue Jul 14, 2022
Merged
bors added a commit to rust-lang/miri that referenced this issue Jul 14, 2022
@bors
Auto merge of #2371 - RalfJung:rustup, r=RalfJung
f8a3553 
rustup

Cc rust-lang/rust#99224
bors added a commit to rust-lang/miri that referenced this issue Jul 14, 2022
@bors
Auto merge of #2371 - RalfJung:rustup, r=RalfJung
5af8b71 
rustup

Cc rust-lang/rust#99224
bors added a commit to rust-lang/miri that referenced this issue Jul 14, 2022
@bors
Auto merge of #2371 - RalfJung:rustup, r=RalfJung
6f6e01e 
rustup

Cc rust-lang/rust#99224
@jyn514
Copy link
Member

jyn514 commented Jul 14, 2022

I think #98975 also broke this. Not sure why highfive didn't notice. Happy to make a PR fixing it :)

@RalfJung
Copy link
Member

Miri was already in test-fail, so it didn't open a new issue for build-fail. Working as intended :)

@RalfJung RalfJung mentioned this issue Jul 14, 2022
Merged
bors added a commit to rust-lang/miri that referenced this issue Jul 14, 2022
@bors
Auto merge of #2372 - RalfJung:rustup, r=RalfJung
3b1eeab 
rustup

Cc rust-lang/rust#99224
@RalfJung
Copy link
Member

rust-lang/miri#2372 fixes this :)

@RalfJung RalfJung mentioned this issue Jul 15, 2022
Merged
@bors bors closed this as completed in c2ecd3a Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RalfJung RalfJung

@oli-obk oli-obk

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
4 participants
@RalfJung @oli-obk @rust-highfive @jyn514