Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup #2371

Merged
merged 2 commits into from
Jul 14, 2022
Merged

rustup #2371

merged 2 commits into from
Jul 14, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 14, 2022

📌 Commit bd69a92 has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jul 14, 2022
@bors
Copy link
Contributor

bors commented Jul 14, 2022

⌛ Testing commit bd69a92 with merge f8a3553...

@bors
Copy link
Contributor

bors commented Jul 14, 2022

💔 Test failed - checks-actions

@fogti
Copy link

fogti commented Jul 14, 2022

ok, this is weird...
failure on win32:

      Running tests\compiletest.rs (target\i686-pc-windows-msvc\release\deps\compiletest-889015c1354de8e2.exe)
## Running ui tests in tests/pass against miri for x86_64-unknown-linux-gnu
[...]
tests/pass\concurrency\sync.rs FAILED
command: "D:\\a\\miri\\miri/target\\i686-pc-windows-msvc\\release\\miri.exe" "--edition" "2018" "-Dwarnings" "-Dunused" "--sysroot" "C:\\Users\\runneradmin\\AppData\\Local\\rust-lang\\miri\\cache" "-Zui-testing" "--target" "x86_64-unknown-linux-gnu" "tests/pass\\concurrency\\sync.rs" "--error-format=json" "-Zmiri-disable-isolation" "-Zmiri-strict-provenance"
Pass got exit code: 1
actual output differed from expected tests/pass\concurrency\sync.stderr
Diff< left / right > :
>error: the main thread terminated without waiting for all remaining threads
>
>note: pass `-Zmiri-ignore-leaks` to disable this check
>
>error: aborting due to previous error

but: this test shouldn't even be executed under win32...

//@ignore-windows: Concurrency on Windows is not supported yet.
//@compile-flags: -Zmiri-disable-isolation -Zmiri-strict-provenance

@RalfJung
Copy link
Member Author

RalfJung commented Jul 14, 2022

Failure is on the win32 host. But the tests are running for a different target ("--target" "x86_64-unknown-linux-gnu" in the logs), and ignore and cfg and everything else in the test are checking the target.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 14, 2022

📌 Commit adf7e56 has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jul 14, 2022
@bors
Copy link
Contributor

bors commented Jul 14, 2022

⌛ Testing commit adf7e56 with merge 5af8b71...

@bors
Copy link
Contributor

bors commented Jul 14, 2022

💔 Test failed - checks-actions

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 14, 2022

📌 Commit 11f2b83 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 14, 2022

⌛ Testing commit 11f2b83 with merge 6f6e01e...

@bors
Copy link
Contributor

bors commented Jul 14, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6f6e01e to master...

@bors bors merged commit 6f6e01e into rust-lang:master Jul 14, 2022
@RalfJung RalfJung deleted the rustup branch July 14, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants