Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: rustc invocations need to depend on the rustc libraries #8057

Closed
pnkfelix opened this issue Jul 26, 2013 · 1 comment
Closed

make: rustc invocations need to depend on the rustc libraries #8057

pnkfelix opened this issue Jul 26, 2013 · 1 comment

Comments

@pnkfelix
Copy link
Member

(creating issue to match PR #7820, since I worry about that growing stale, and there are some things like labels that you can use with filed Issues that you cannot use with pull requests.)

As written in Makefile.in, $(STAGE$(1)T$(2)H$(3)) is the way one
writes an invocation of rustc where $(1) is the stage number $(2) is
the target triple $(3) is the host triple. (Other uses of the macro
may plug in actual values or different parameters in for those three
formal parameters.)

When you have invocations of $(STAGE...), you need to make sure that
its dependences are satisfied; otherwise, if someone is using make -jN for certain (large-ish) N, one can encounter situations where
GNU make attempts to invoke rustc before it has actually copied some
of its libraries into place, such as libmorestack.a, which causes a
link failure when the rustc invocation attempts to link in those
libraries.

In this case, the main prerequisite to add is TSREQ$(1)T$(2)H$(3),
which is described in Makefile.in as "Prerequisites for using the
stageN compiler to build target artifacts"

@pnkfelix
Copy link
Member Author

Part of #8058

@bors bors closed this as completed in 44808fc Jul 26, 2013
@pnkfelix pnkfelix removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 2, 2021
Rustup

r? `@ghost`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant