Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows native io tests are failing #12516

Closed
huonw opened this issue Feb 24, 2014 · 3 comments
Closed

Windows native io tests are failing #12516

huonw opened this issue Feb 24, 2014 · 3 comments
Labels
O-windows Operating system: Windows

Comments

@huonw
Copy link
Member

huonw commented Feb 24, 2014

Windows is reliably failing with

task 'io::fs::test::truncate_works::native' failed at 'receiving on a closed channel', C:\bot\slave\auto-win-32-nopt-t\build\src\libstd\comm\mod.rs:507

and

task 'io::net::unix::tests::read_eof::native' failed at 'receiving on a closed channel', C:\bot\slave\try-win\build\src\libstd\comm\mod.rs:507

Seems to correlate with #12380 landing.
@huonw
Copy link
Member Author

huonw commented Feb 24, 2014

cc @alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 24, 2014
@alexcrichton
Correctly ignore some tests on windows
1dda504 
These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc rust-lang#12516
@alexcrichton alexcrichton mentioned this issue Feb 24, 2014
Merged
bors added a commit that referenced this issue Feb 24, 2014
@bors
auto merge of #12523 : alexcrichton/rust/ignore-some-windows-tests, r…
97420d6 
…=pnkfelix

These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc #12516
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 24, 2014
@alexcrichton
Correctly ignore some tests on windows
c0e767b 
These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc rust-lang#12516
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 24, 2014
@alexcrichton
windows: Fix the test_exists unit test
13a8fcd 
Turns out the `timeout` command was exiting immediately because it didn't like
its output piped. Instead use `ping` repeatedly to get a process that will sleep
for awhile.

cc rust-lang#12516
bors added a commit that referenced this issue Feb 24, 2014
@bors
auto merge of #12523 : alexcrichton/rust/ignore-some-windows-tests, r…
68a4f7d 
…=pnkfelix

These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc #12516
@alexcrichton
Copy link
Member

The process tests have been fixed, I've never seen the unix read_eof failure before, and the truncate test is still flaky (and ignore)

alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 27, 2014
@alexcrichton
std: Small cleanup and test improvement
843c5e6 
This weeds out a bunch of warnings building stdtest on windows, and it also adds
a check! macro to the io::fs tests to help diagnose errors that are cropping up
on windows platforms as well.

cc rust-lang#12516
@alexcrichton
Copy link
Member

Closing, this seems to have settled down now. We should have better error reporting in place for when this comes back

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2024
@bors
Auto merge of rust-lang#12516 - humannum14916:assigning_clones_msrv, …
5b7efe8 
…r=Alexendoo

Make `assigning_clones` MSRV check more precise

Continuation of rust-lang#12511

`clone_into` is the only suggestion subject to the 1.63 MSRV requirement, and the lint should still emit other suggestions regardless of the MSRV.

changelog: [assigning_clones]: only apply MSRV check to `clone_into` suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @huonw