Skip to content

Commit

Permalink
Correctly ignore some tests on windows
Browse files Browse the repository at this point in the history
These two tests are notoriously flaky on the windows bots right now, so I'm
ignoring them until I can investigate them some more. The truncate_works test
has been flaky for quite some time, but it has gotten much worse recently. The
test_exists test has been flaky since the recent std::run rewrite landed.
Finally, the "unix pipe" test failure is a recent discovery on the try bots. I
haven't seen this failing much, but better safe than sorry!

cc rust-lang#12516
  • Loading branch information
alexcrichton committed Feb 24, 2014
1 parent 6720977 commit c0e767b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions src/libstd/io/fs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1106,9 +1106,8 @@ mod test {
file.fsync().unwrap();
file.datasync().unwrap();
drop(file);
})
} #[ignore(cfg(windows))])

#[ignore(cfg(windows))] // FIXME(#11638)
iotest!(fn truncate_works() {
let tmpdir = tmpdir();
let path = tmpdir.join("in.txt");
Expand Down Expand Up @@ -1138,7 +1137,7 @@ mod test {
assert_eq!(File::open(&path).read_to_end().unwrap(),
(bytes!("fo", 0, 0, 0, 0, "wut")).to_owned());
drop(file);
})
} #[ignore(cfg(windows))]) // FIXME(#11638)

iotest!(fn open_flavors() {
let tmpdir = tmpdir();
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/io/net/unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ mod tests {
}, proc(_client) {
// drop the client
})
})
} #[ignore(cfg(windows))]) // FIXME(#12516)

iotest!(fn write_begone() {
smalltest(proc(mut server) {
Expand Down
3 changes: 1 addition & 2 deletions src/libstd/io/process.rs
Original file line number Diff line number Diff line change
Expand Up @@ -823,11 +823,10 @@ mod tests {
assert!(!p.wait().success());
})

#[ignore(cfg(windows))]
iotest!(fn test_exists() {
let mut p = sleeper();
assert!(Process::kill(p.id(), 0).is_ok());
p.signal_kill().unwrap();
assert!(!p.wait().success());
})
} #[ignore(cfg(windows))]) // FIXME(#12516)
}

0 comments on commit c0e767b

Please sign in to comment.