feat: Implement diagnostic for await outside of async
#17791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Aug 5, 2024
crates/hir-def/src/body/lower.rs
Outdated
| @@ -100,6 +101,8 @@ struct ExprCollector<'a> { | |||
| // resolution | |||
| label_ribs: Vec<LabelRib>, | |||
| current_binding_owner: Option<ExprId>, | |||
|
|
|||
| awaitable_blocks: Vec<Awaitable>, | |||
There was a problem hiding this comment.
Hmm, an Option<Awaitable> should suffice here, which would be replaced with coroutine_kind after #16173. In fact you can probably take a peek at how that PR sets coroutine_kind. Mihgt be simple enough to copy if the changes aren't drastic in there.
Then we just need to swap whenever we enter and exit a context like we do with other Option/bool things here
ShoyuVanilla
force-pushed
the
await-outside-of-async
branch
from
eb4ac5f
to
8a51419
Compare
Veykril
approved these changes
Aug 5, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17781