-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gen
block and function parsing
#16173
base: master
Are you sure you want to change the base?
Conversation
Of note here is that our parsing is currently not edition aware at all (we just assume edition 2021 parsing), so we need to fix that first (as a separate PR if any). |
da18904
to
67415c7
Compare
Is this ready for review? Note that this won't be merged until we have solved the edition dependent parsing, as |
It's not ready for review (I realize marking as draft is not enough as you also use the S-waiting-on-author label), I mostly opened this PR to avoid duplicate work and to allow others to look at my messy code and use this if they need it. I would definitely need to clean this up before a review and if somebody else wants to take parts of this that's also fine as this is my first PR to rust-analyzer and I only have a very limited understanding of many parts of it that I touched here. |
☔ The latest upstream changes (presumably #16256) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #16447) made this pull request unmergeable. Please resolve the merge conflicts. |
#17620 should implement the parsing in an edition aware manner, unblocking the remainder of this |
That's nice! I'm currently writing my thesis so I probably won't have time for this. So anybody feel free to take this over. |
Squashed and rebased |
☔ The latest upstream changes (presumably #17791) made this pull request unmergeable. Please resolve the merge conflicts. |
#16156
Blocked on #16324
Things I need help with / need some pointers and TODOs:
Only parsegen
as keyword in 2024 editiongen
in hovergen
in block doesn't show keyword information. (no doc like https://doc.rust-lang.org/nightly/std/keyword.await.html forgen
andyield
)gen
keyword dustypomerleau/rust-syntax#41)gen fn
andasync gen fn