Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gen block and function parsing #16173

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Dec 21, 2023

#16156

Blocked on #16324

Things I need help with / need some pointers and TODOs:

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2023
@Veykril
Copy link
Member

Veykril commented Dec 22, 2023

Only parse gen as keyword in 2024 edition

Of note here is that our parsing is currently not edition aware at all (we just assume edition 2021 parsing), so we need to fix that first (as a separate PR if any).

@mohe2015 mohe2015 force-pushed the parse-gen branch 6 times, most recently from da18904 to 67415c7 Compare December 25, 2023 23:00
@Veykril
Copy link
Member

Veykril commented Jan 3, 2024

Is this ready for review? Note that this won't be merged until we have solved the edition dependent parsing, as gen is a heavily used identifier I imagine.

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2024
@mohe2015
Copy link
Contributor Author

mohe2015 commented Jan 3, 2024

It's not ready for review (I realize marking as draft is not enough as you also use the S-waiting-on-author label), I mostly opened this PR to avoid duplicate work and to allow others to look at my messy code and use this if they need it. I would definitely need to clean this up before a review and if somebody else wants to take parts of this that's also fine as this is my first PR to rust-analyzer and I only have a very limited understanding of many parts of it that I touched here.

@bors
Copy link
Contributor

bors commented Jan 5, 2024

☔ The latest upstream changes (presumably #16256) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 30, 2024

☔ The latest upstream changes (presumably #16447) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member

Veykril commented Jul 19, 2024

#17620 should implement the parsing in an edition aware manner, unblocking the remainder of this

@mohe2015
Copy link
Contributor Author

That's nice! I'm currently writing my thesis so I probably won't have time for this. So anybody feel free to take this over.

@Veykril
Copy link
Member

Veykril commented Jul 25, 2024

Squashed and rebased

@bors
Copy link
Contributor

bors commented Aug 5, 2024

☔ The latest upstream changes (presumably #17791) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants