Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Update clippy #768

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Update clippy #768

merged 1 commit into from
Mar 16, 2018

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Mar 16, 2018

Wouldn't wildcard help here?
I mean if you want to build rls with clippy on latest nightly you (usually) have to use last version of clippy anyway.

Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
@alexheretic
Copy link
Member

Wouldn't wildcard help here?

That's true, I also thought this. But I suppose having the version in vcs is useful if you're checking out an old commit for use with an older compiler. I'm not sure if that matters to anyone in reality though. Either way it probably isn't a big deal.

@Xanewok
Copy link
Member

Xanewok commented Mar 16, 2018

Agreed, I'm leaning a bit more towards keeping it in the file for the reason mentioned by @alexheretic.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants