Update to latest Cargo master #767
Conversation
Cargo.toml
Outdated
| @@ -10,8 +10,7 @@ categories = ["development-tools"] | |||
| build = "build.rs" | |||
|
|
|||
| [dependencies] | |||
| # cargo hash delivered with nightly-2018-03-14 | |||
| cargo = { git = "https://github.com/rust-lang/cargo", rev = "5f83bb4044f32b60d06717c609610f67411fc671" } | |||
| cargo = { git = "https://github.com/rust-lang/cargo" } | |||
There was a problem hiding this comment.
Could we keep the rev? I think it is useful for RLS devs to have a consistent version of Cargo, even if when we embed in Rust, we get whatever Rust has.
There was a problem hiding this comment.
Sure yeah, but just to confirm, doesn't Cargo.lock do that already? With the rev in here it means that Cargo can't be updated w/o editing the Cargo.toml
There was a problem hiding this comment.
Referring to the hash allows frequent use of cargo update in a non-breaking way. We had it in the lock before but that seemed to encourage not using cargo update. See #680. Maybe there's a better way?
There was a problem hiding this comment.
Ok! For big projects I wouldn't necessarily recommend cargo update as it can change quite a lot but I'll add this back in
alexcrichton
force-pushed
the
update-cargo
branch
2 times, most recently
from
685d7af
to
35d569a
Compare
|
Oops, I created a conflict with merging #768, sorry! @alexcrichton could you rebase it again, please? |
alexcrichton
force-pushed
the
update-cargo
branch
from
35d569a
to
c0f07b3
Compare
|
Sure thing, done! |
|
Thanks! |
No description provided.