This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Use ManifestError & ResolveError APIs to highlight workspace member Cargo.toml errors #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexheretic
force-pushed
the
workspace-member-manifest-diagnostics
branch
2 times, most recently
from
cd208fe to
6ed5231
Compare
alexheretic
force-pushed
the
workspace-member-manifest-diagnostics
branch
from
6ed5231 to
3e45874
Compare
|
This is now ready to go as cargo is new enough in rust-lang/rust. |
alexheretic
changed the title
Update cargo -> 2d0863f657e6f45159fc7412267eee3e659185e5 Update clippy 5afdf8b78507ddf015d192858aef56e72c17de16
alexheretic
force-pushed
the
workspace-member-manifest-diagnostics
branch
from
3e45874 to
27da9fd
Compare
|
That's a wonderful addition, thanks! Sorry it took some time to review. bors r+ |
|
Hm, bors has a hard time catching up (maybe due to recent GitHub issues)? This seems to be the newest commit on master and the CI looks green, so let's give it a try! |
|
Not awaiting review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1079 and rust-lang/cargo#6157 we can use cargo
ManifestErrorchains &ResolveErrors to discern a more precise manifest in the workspace to highlight as erroneous.This means things like toml parse errors in a member manifest will be correctly targeted in a diagnostic.
I've also added
ResolveErrorsupport following the rust-lang/cargo#6175 merge. This allows us to find a member manifest when reporting dependency resolution errors during workspace compilation.