Add PackageError wrappers for activation errors #6175
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for this! I wonder if a better name might be |
Yes perhaps, I named it for what it provides (package id) thinking maybe we could use it in other places to provide the same thing. But I wouldn't it having a more specific name, so I'll take your lead. |
Rename package_id() -> parent_package_id() for clarity
|
As an example of what I'm going for this patch; integrated into RLS this change allows me to generate the following diagnostic on a workspace member manifest. |
More useful than just the parent
Move activation_error, describe_path -> errors.rs
alexheretic
force-pushed
the
compile_package_errors
branch
from
3c7737a to
a853efd
Compare
|
@bors: r+ Thanks @alexheretic and @Eh2406! |
|
📌 Commit 3c7737a39bead82e2f6e2e8cae4657f89e1dff0b has been approved by |
|
3c7737a is not the correct commit, I force pushed a853efd very shortly after making it. The former missed removing the old ResolveError implementation. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📌 Commit a853efd has been approved by |
Add PackageError wrappers for activation errors Similarly to #6157 this wraps compile errors with `PackageId` info to allow lib users, in this case rls, to discern where something went wrong. In particular if a dependency has a dodgy version or doesn't exist the error chain will now contain a <s>PackageError that provides the package id</s> `ResolveError` that provides the package path from error-parent -> root. From this I figure out if the error better relates to a workspace member, and target that manifest for diagnostics.
|
💥 Test timed out |
|
copied down the case of @bors retry |
|
⌛ Testing commit a853efd with merge 320fde11afdfa08cd643a31f8c593e8208aaf01e... |
Add PackageError wrappers for activation errors Similarly to #6157 this wraps compile errors with `PackageId` info to allow lib users, in this case rls, to discern where something went wrong. In particular if a dependency has a dodgy version or doesn't exist the error chain will now contain a <s>PackageError that provides the package id</s> `ResolveError` that provides the package path from error-parent -> root. From this I figure out if the error better relates to a workspace member, and target that manifest for diagnostics.
|
☀️ Test successful - status-appveyor, status-travis |
Similarly to #6157 this wraps compile errors with
PackageIdinfo to allow lib users, in this case rls, to discern where something went wrong.In particular if a dependency has a dodgy version or doesn't exist the error chain will now contain a
PackageError that provides the package idResolveErrorthat provides the package path from error-parent -> root. From this I figure out if the error better relates to a workspace member, and target that manifest for diagnostics.