Several fixes for Linux/musl/s390x #4549
Open
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgross35 I probably missed some of the finer details of version tracking in the libc crate. I'm looking forward to your (and/or someone else's) review |
neuschaefer
force-pushed
the
s390x-statfs
branch
from
c280654 to
62da8b9
Compare
tgross35
requested changes
Aug 10, 2025
neuschaefer
force-pushed
the
s390x-statfs
branch
3 times, most recently
from
adbe903 to
e3f7cad
Compare
|
@tgross35 this is ready for review again |
tgross35
reviewed
Aug 12, 2025
Comment on lines
89
to
94
| s_no_extra_traits! { | ||
| // FIXME(union): This is actually a union. | ||
| pub struct fpreg_t { | ||
| pub union fpreg_t { | ||
| pub d: c_double, | ||
| // f: c_float, | ||
| pub f: c_float, | ||
| } | ||
| } |
There was a problem hiding this comment.
Noting to self that this patch won't get backported
tgross35
approved these changes
Aug 12, 2025
tgross35
added
the
stable-nominated
tgross35
requested changes
Aug 13, 2025
Good point. I'll follow 051fa61 and make the traits |
https://git.musl-libc.org/cgit/musl/tree/arch/s390x/bits/statfs.h statfs64 is the same as statfs on musl-libc, so it can also be a type alias on the Rust side. https://git.musl-libc.org/cgit/musl/tree/include/sys/statfs.h#n21
glibc provides these symbols, but musl does not.
musl-libc does not implement sysctl.
SYS_mseal is not yet defined in musl-libc, but it can only take one possible value, dictated by the kernel's syscall ABI.
Previously, the definition was only changed for glibc but not for musl. Fixes: 051fa61 ("Make `fpreg_t` an union")
auto-merge was automatically disabled
August 13, 2025 12:39
Head branch was pushed to by a user without write access
neuschaefer
force-pushed
the
s390x-statfs
branch
from
e3f7cad to
31ee4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates several APIs with respect to their definitions in musl-libc.
Sources
Links are included in the commit messages.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI