-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "placeholder constants" #3131
Comments
👍, before 0.3, I'd like to deprecate these values. |
Noticed that we have a lot of |
Mention unstable values on PR template cc #3131
An alternative to deleting these placeholder constants would be to still provide them but not make any guarantees about their value moving forward. This means that we would be free to change the value of these constants without it being considered a breaking change. CI tests should specifically exclude these, although it would be nice to make CI fail only if our value for such constants is lower than the one on the system. |
It's common for C APIs to define constant values to denote the "last" value in a set of constants, like
ELAST
orIPPROTO_MAX
. This seems prone to weird bugs, and these constants provide very marginal benefit to Rust programmers. Since we're considering some breakage anyways, we should just remove these values where we are made aware of them.See:
The text was updated successfully, but these errors were encountered: