Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/add missing AF_XDP structs & constants #3956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arctic-alpaca
Copy link
Contributor

Description

This PR adds missing structs/constants from the if_xdp.h header and updates the xdp_umem_reg struct. Due to the added field in xdp_umem_reg, this is a breaking change from the 0.2 branch.

Ideally, I would like to include all the changes in the 0.2 branch. Would it be possible to add a xdp_umem_reg_v3 to not break the current xdp_umem_reg?
If not, how would deprecating a struct to change it work? Just add a deprecation notice, wait for X amount of time, add the field?

Sources

AF_XDP documentation: https://docs.kernel.org/networking/af_xdp.html
Header file: https://github.com/torvalds/linux/blob/v6.11/include/uapi/linux/if_xdp.h

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

I could not test the the changes locally due to the error described in #3865 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Oct 1, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants