Update syn, quote and proc-macro2
#940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcpl
commented
Apr 4, 2018
| @@ -573,19 +573,19 @@ if_nightly! { | |||
| let mut spans = Tokens::new(); | |||
| tokens.to_tokens(&mut spans); | |||
| let good_tokens = proc_macro2::TokenStream::from(spans).into_iter().collect::<Vec<_>>(); | |||
| let first_span = good_tokens.first().map(|t| t.span).unwrap_or(Span::def_site()); | |||
| let last_span = good_tokens.last().map(|t| t.span).unwrap_or(first_span); | |||
| let first_span = good_tokens.first().map(|t| t.span()).unwrap_or(Span::call_site()); | |||
There was a problem hiding this comment.
Should this really be call_site or better to make first_last function to return proc_macro::Span?
This was referenced Apr 11, 2018
|
This looks good, just had github rebase it and will merge if its green :) |
|
It looks like nightly has changed a bit more in the past week and there's a bit more needed to get this green. |
|
Ouch, forgot to rebuild this when rust-lang/rust#49597 got merged. Will fix that! |
|
Thanks! Looks good ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.