Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Fix nightly breakage from proc-macro #88

Closed
wants to merge 3 commits into from
Closed

Fix nightly breakage from proc-macro #88

wants to merge 3 commits into from

Conversation

peterdelevoryas
Copy link

@peterdelevoryas peterdelevoryas commented Apr 10, 2018

This is supposed to fix #87, I'm not entirely sure if these are all of the necessary changes! cargo test and cargo clean; cd testcrate; cargo test succeed, but besides that I'm not sure what to test. It just updates proc-macro2 usage from 0.2 to 0.3. Also, is futures-await even the correct place to be going for #[async] and await!()? I see that futures-rs now contains the macro crates, but I can't find a version (0.2.0, 0.2.0-alpha, 0.2.0-beta don't seem to work, and 0.1.21 doesn't seem to have it, and I can't find a git revision that works either). Also, I noticed that the not found error is currently breaking Travis for futures-rs) for that works (I always get #[async] not found, and I am using features = ["nightly"]).

Edit: Oh, also, tests/smoke.rs usage of ThreadPool needs to be updated to have unwrap() in order for cargo test to work, I have another branch in my fork that makes this change, but I didn't include it in this PR.

Edit2: Actually, just to make Travis succeed, I added the tests/smoke.rs update! Not sure if this is desired.

Nightly version 2018-04-06 broke the crate because
of the new proc-macro api, which broke using proc-macro2
v0.2, so updating to proc-macro2 v0.3 (and updating
corresponding quote and syn versions) was necessary.
@seunlanlege
Copy link

Lol, and here i spent more than an hour doing the same thing 😂

@seunlanlege seunlanlege mentioned this pull request Apr 10, 2018
@hcpl hcpl mentioned this pull request Apr 11, 2018
@berkus
Copy link

berkus commented Apr 11, 2018

Matching PR on the futures-rs side: rust-lang/futures-rs#940 (by @hcpl )

@withoutboats
Copy link
Collaborator

Hey @peterdelevoryas thanks for the PR! Unfortunately, the situation around futures-await has gotten a bit complicated.

We've upstreamed the 0.2 version of futures-await into futures-rs proper. We'd like to use this repo to track futures-await 0.1 - in particular, the latest version of futures-await on crates.io is broken on the latest nightly, so we'd like to upgrade it to no longer be broken. However, the master branch of this repo curently tracks futures-await 0.2 - the version that has now been folded into futures-rs.

So what we need to do is revert this back to the most recent commit that was the 0.1 branch and then get it passing CI on nightly. I did the revert in #86, but haven't gotten it green.

This PR makes the 0.2 version green, but we no longer want to track the 0.2 version using this repo! It looks like rust-lang/futures-rs#940 is the same PR but in futures-rs; I'll merge that PR into futures-rs, but we still need this repo to track 0.1 so we can release a fixed version for everyone whose been using futures-await 0.1.

@seunlanlege
Copy link

@withoutboats i'll re-open #89. can you check it out? looks like the testcrate is failing.

@berkus
Copy link

berkus commented Apr 11, 2018

@withoutboats so you say the await/async stuff should be in futures-rs and working now? (Provided that rust-lang/futures-rs#940 is merged there)

@berkus
Copy link

berkus commented Apr 11, 2018

Also, if I may ask, what is the reason for going backwards in version not forwards? Is futures-await going to become maintenance-mode-only-legacy-repo?

@withoutboats
Copy link
Collaborator

@berkus I think there are other outstanding PRs to get it working, but the intention is to release a futures 0.2.1 in the near future which supports #[async] and await! out of the box (on nightly)

@withoutboats
Copy link
Collaborator

closing this because its been superceded by #89 and #86

@berkus
Copy link

berkus commented Apr 11, 2018

@withoutboats thanks, I'm looking forward for 0.2.1 of futures-rs

@withoutboats
Copy link
Collaborator

Also, if I may ask, what is the reason for going backwards in version not forwards? Is futures-await going to become maintenance-mode-only-legacy-repo?

Yes, that's the case! This is just a maintenance mode crate, further feature development of the #[async] macros and such should go in rust-lang-nursery/futures-rs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on current nightly
4 participants