admin::render_readmes: Support broader implicit readmes #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2021
Achieves this by pulling the entire tar file into memory in the form of a hashmap. Then we can look for the files as needed. Before, we would stream the pkg response from the server and un-tar it on the fly, but this behavior is incorrect if the Cargo.toml isn't at the beginning of the archive. Could imagine this might be problematic if the entire archive won't fit in memory - but that seems unlikely? We could mitigate by limiting to certain file types, but we won't know what type the README will be. Added a test to for this case - the test fails before this change and passes with this change
Support readme = false, and readme omitted per https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field
nipunn1313
force-pushed
the
rerender_readme5
branch
from
e29a19e to
6198360
Compare
|
Closing based on discussion - not planning to maintain admin::render_readmes in this state. Ideally admin::render_readmes is not downloading anything from crates-io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3971
(Because of community/community#4477 - github ends up rendering the diffs together. Go to the commits tab and just look at the most recent commit to review).
Fixes the comment here #3970 (comment)