-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support admin render_readme with Cargo.toml without optional readme field #3970
Conversation
☔ The latest upstream changes (presumably #3969) made this pull request unmergeable. Please resolve the merge conflicts. |
89dc057
to
6b7b5a1
Compare
Now that I read the docs on this a little more closely I'm wondering how we are handling |
6b7b5a1
to
6d22138
Compare
I've rebased the branch btw :) |
yep you're right. There's more to the spec that's not supported. Let me see what I can do. |
6d22138
to
6a67076
Compare
6a67076
to
824055f
Compare
#3971 adds support for out-of-order tar files I know there are timezones and whatnot between us, so feel free to update/change these PRs to get as much done as you'd like. |
@bors r+ |
📌 Commit 824055f has been approved by |
Support admin render_readme with Cargo.toml without optional readme field Depends on #3969 (Because of community/community#4477 (comment) - github ends up rendering both diffs together. Go to the commits tab and just look at the most recent commit to review). https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field
💥 Test timed out |
probably caused by https://www.githubstatus.com/incidents/bdbzpz7qxmbx @bors retry |
☀️ Test successful - checks-actions |
Depends on #3969
(Because of community/community#4477 (comment) - github ends up rendering both diffs together. Go to the commits tab and just look at the most recent commit to review).
https://doc.rust-lang.org/cargo/reference/manifest.html#the-readme-field