Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused macros #165

Merged
merged 1 commit into from
Jun 1, 2017
Merged

remove unused macros #165

merged 1 commit into from
Jun 1, 2017

Conversation

japaric
Copy link
Member

@japaric japaric commented Jun 1, 2017

to fix warnings

@japaric
remove unused macros
b2f72e1 
to fix warnings
@japaric
Copy link
Member Author

japaric commented Jun 1, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2017

📌 Commit b2f72e1 has been approved by japaric

@bors
Copy link
Contributor

bors commented Jun 1, 2017

⌛ Testing commit b2f72e1 with merge f18510a...

bors added a commit that referenced this pull request Jun 1, 2017
@bors
Auto merge of #165 - rust-lang-nursery:fix-warnings, r=japaric
f18510a 
remove unused macros

to fix warnings
@japaric japaric mentioned this pull request Jun 1, 2017
Merged
@bors
Copy link
Contributor

bors commented Jun 1, 2017

💔 Test failed - status-travis

@japaric
Copy link
Member Author

japaric commented Jun 1, 2017

MIPSel failure while testing floattidf. This has nothing to do with this change:

thread 'floattidf' panicked at 'assertion failed: (left == right) (left: ((-3518437208883100,), 14318300716730535424, 14318300716730535168, true), right: ((-3518437208883100,), 14318300716730535424, 14318300716730535168, false))', /target/mipsel-unknown-linux-gnu/debug/build/compiler_builtins-8619b5d3e04f0666/out/floattidf.rs:10055

Looks like the value computed on the host as the correct answer is wrong. -3518437208883100_i128 casted to f64 is -3518437208883100_f64 which transmuted to u64 is 14062771311441084216_u64. That value doesn't match the 14318300716730535424_u64 from the failure message. Maybe there was some UB in the generation of a previous test case? cc @est31

@bors retry

bors added a commit that referenced this pull request Jun 1, 2017
@bors
Auto merge of #165 - rust-lang-nursery:fix-warnings, r=japaric
d63757c 
remove unused macros

to fix warnings
@bors
Copy link
Contributor

bors commented Jun 1, 2017

⌛ Testing commit b2f72e1 with merge d63757c...

@est31
Copy link
Member

est31 commented Jun 1, 2017

Yeah the tests are unfortunately a bit spurious.

@bors
Copy link
Contributor

bors commented Jun 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing d63757c to master...

@bors bors merged commit b2f72e1 into master Jun 1, 2017
@japaric japaric deleted the fix-warnings branch June 1, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@japaric @bors @est31