-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x86_64-linux-android build support #98
Conversation
Target x86_64-android-linux was recently added. |
Thanks, @malbarbo! @homunkulus r+ |
📌 Commit 528480f has been approved by |
💔 Test failed - status-travis |
The error seems to be unrelated. Let's try again? |
The PowerPC problem should be fixed now. @homunkulus r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 528480f has been approved by |
@homunkulus retry |
Add x86_64-linux-android build support
💔 Test failed - status-travis |
Unrelated again? |
|
I saw the wrong log, sorry. I think that chrono (and time) dependency (rust-lang/cargo#4069) was removed in the middle of the test! That bad luck! Maybe we can fix a revision... Fixed now. |
Thanks. Let's try again. @homunkulus r+ BTW, could you please next time push a new commit rather than amend the last one. That way it's easier for me to see the latest change you made. |
📌 Commit 125db52 has been approved by |
Add x86_64-linux-android build support
💔 Test failed - status-travis |
The problem is the new lint rust-lang/rust#41907. How should we proceed? Use a specific version of nightly? It seems that using nightly and head of git repositories of cargo, etc, is a fragile approach... |
Oh, sorry for that. |
@japaric How can we proceed with this? |
There's a fix for the unused macro warning / error in rust-lang/compiler-builtins#165. We could shield us from some of these problems using "--cap-lints" (I think that was the name of the flag) to ignore warnings / errors due to warnings. |
Thanks for fixing it. According to https://github.com/rust-lang/rfcs/blob/master/text/1193-cap-lints.md the option is |
Let's try again? |
@homunkulus r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 125db52 has been approved by |
@homunkulus retry |
Add x86_64-linux-android build support
☀️ Test successful - status-travis |
No description provided.