Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request hidden opaque types lazily #478

Merged
merged 2 commits into from
May 27, 2020
Merged

Request hidden opaque types lazily #478

merged 2 commits into from
May 27, 2020

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented May 27, 2020 •
edited
Loading

For context, see these comments

nikomatsakis
nikomatsakis requested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right. One nit

chalk-solve/src/lib.rs Outdated Show resolved Hide resolved
@detrumi detrumi force-pushed the lazy-opaque-types branch from 4af8fb9 to a094046 Compare May 27, 2020 15:01
@nikomatsakis nikomatsakis merged commit 5a3b871 into rust-lang:master May 27, 2020
@detrumi detrumi deleted the lazy-opaque-types branch May 27, 2020 18:28
@detrumi detrumi mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@detrumi @nikomatsakis