Generate auto trait clauses for opaque type goals #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detrumi
force-pushed
the
opaque-auto-traits
branch
from
d362b5e to
8a3e89f
Compare
detrumi
commented
May 22, 2020
nikomatsakis
requested changes
May 23, 2020
| opaque_id | ||
| ); | ||
|
|
||
| let opaque_ty_datum = &builder.db.opaque_ty_data(opaque_id); |
There was a problem hiding this comment.
Reminder that we should factor the "hidden type" out from this struct and make it something that we lazilly request
There was a problem hiding this comment.
How would that work, actually? A method on the database to request it, or something similar?
There was a problem hiding this comment.
Yeah, just a separate method on the db that only gets invoked when auto trait impls are actually required (that's important) would be fine, I think
nikomatsakis
approved these changes
May 26, 2020
| @@ -161,7 +224,12 @@ fn program_clauses_that_could_match<I: Interner>( | |||
|
|
|||
| if trait_datum.is_non_enumerable_trait() || trait_datum.is_auto_trait() { | |||
| let self_ty = trait_ref.self_type_parameter(interner); | |||
| if self_ty.bound_var(interner).is_some() | |||
|
|
|||
| if let TyData::Alias(AliasTy::Opaque(opaque_ty)) = self_ty.data(interner) { | |||
There was a problem hiding this comment.
I think this probably wants to be the placeholder, and not the alias type, but we can leave it as "future work" for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have
opaque type Foo: Trait = Bar,solving the goal
Foo: Sendwill generate
Foo: Send :- Bar: Send